Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Maniphest Tasks

T68974: Collection usability

Commits

rB92736a7b7592: Per-Viewport Collection Visibility

Summary

Support per-viewport collection visibility options.

Note: There is no way to show a collection that was not visible before
due to depsgraph. Otherwise we would risk having all the collections in
the depsgraph and I believe this is not the idea.

An alternative would be to have a new depsgraph for viewports that are
not local. Something to keep in mind if we do per-viewport current frame
in the future.

So for now what we do is to only allow collections visibility to be
disabled/hidden in this mode.

Diff Detail

Repository: rB Blender

Event Timeline

Dalai Felinto (dfelinto) created this revision.Aug 27 2019, 9:56 PM

Harbormaster completed remote builds in B4627: Diff 17597.Aug 27 2019, 9:56 PM

Design task: T68940

Dalai Felinto (dfelinto) added a task: T68974: Collection usability.Sep 5 2019, 4:28 PM

It's somewhat a shame that you can only enable a subset of Collections per viewport, although still a useful feature.

Suggestion: Maybe if you enable a Collection in a viewport that is not enabled in the View Layer, it also gets evaluated in depsgraph, and so it becomes possible to enable any Collection?

Dalai Felinto (dfelinto) mentioned this in T69546: Tag or clear 2.81 Milestone Tasks.Sep 5 2019, 5:25 PM

Small cleanup, removing commented out code

Harbormaster completed remote builds in B4874: Diff 18040.Sep 10 2019, 3:23 PM

Implement resetting on file load

When loading with no UI it resets all uuids.
When loading with ui it still tries to clear up the unused uuids.

Harbormaster completed remote builds in B4885: Diff 18058.Sep 10 2019, 6:23 PM

Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)Sep 10 2019, 6:24 PM

Brecht Van Lommel (brecht) added inline comments.Sep 13 2019, 12:20 PM

source/blender/makesrna/intern/rna_space.c
3970	Rename to Local Collections? We use "Local Camera" in the view settings and I think this is the same type of thing. It used to be called "lock" in 2.7, but I think that's not really a clear name and different from how we use the term "lock" elsewhere in the UI.

hide_viewport (the eye icon in the outliner) is not used by the depsgraph. So I think collections hidden this way can still be visible as local collections.

We do want to make the depsgraph respect this in the future (for performance reasons), but there is nothing preventing us to take local collections into account for that as well.

This revision is now accepted and ready to land.Sep 13 2019, 12:28 PM

From review rename: lock -> local

Harbormaster completed remote builds in B4944: Diff 18189.Sep 13 2019, 12:55 PM

Closed by commit rB92736a7b7592: Per-Viewport Collection Visibility (authored by Dalai Felinto (dfelinto)). · Explain WhySep 13 2019, 5:49 PM

This revision was automatically updated to reflect the committed changes.

Dalai Felinto (dfelinto) added a commit: rB92736a7b7592: Per-Viewport Collection Visibility.

Per-Viewport Collection Visibility
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 18211

release/scripts/startup/bl_ui/space_view3d.py

source/blender/blenkernel/BKE_layer.h

source/blender/blenkernel/intern/layer.c

source/blender/blenkernel/intern/object_update.c

source/blender/blenloader/intern/versioning_280.c

source/blender/draw/intern/draw_manager.c

source/blender/editors/include/ED_view3d.h

source/blender/editors/object/object_edit.c

source/blender/editors/space_view3d/view3d_view.c

source/blender/makesdna/DNA_layer_types.h

source/blender/makesdna/DNA_object_types.h

source/blender/makesdna/DNA_scene_types.h

source/blender/makesdna/DNA_view3d_types.h

source/blender/makesrna/intern/rna_layer.c

source/blender/makesrna/intern/rna_space.c

source/blender/windowmanager/intern/wm_files.c

Per-Viewport Collection VisibilityClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18211

release/scripts/startup/bl_ui/space_view3d.py

source/blender/blenkernel/BKE_layer.h

source/blender/blenkernel/intern/layer.c

source/blender/blenkernel/intern/object_update.c

source/blender/blenloader/intern/versioning_280.c

source/blender/draw/intern/draw_manager.c

source/blender/editors/include/ED_view3d.h

source/blender/editors/object/object_edit.c

source/blender/editors/space_view3d/view3d_view.c

source/blender/makesdna/DNA_layer_types.h

source/blender/makesdna/DNA_object_types.h

source/blender/makesdna/DNA_scene_types.h

source/blender/makesdna/DNA_view3d_types.h

source/blender/makesrna/intern/rna_layer.c

source/blender/makesrna/intern/rna_space.c

source/blender/windowmanager/intern/wm_files.c

Per-Viewport Collection Visibility
ClosedPublic
Actions

Revision Contents
Changeset List