Differential D5621
UI: Graph Editor: Use dopesheet keyframe markers and colours Authored by Charlie Jolly (charlie) on Aug 28 2019, 10:29 PM.
Details This changes the marker shapes and colours to match the dopesheet. Benefits:
Diff Detail
Event TimelineComment Actions Feedback from the animation module members here at the Blender Institute is that they think displaying keyframe types in the graph editor is a good idea. However there are some issue with the way they are displayed in the dopesheet now, and we should make some changes there before adding it into more areas. There will be a design / plan for that in about 2-3 weeks from now, we're waiting for @Sybren A. Stüvel (sybren) to be back from vacation. Comment Actions The proposal on Right Click Select is about the colour of the keyframes, whereas this patch deals with the shapes indicating the handle type. The colouring-the-keyframes feature is loved by @Hjalti Hjálmarsson (hjalti) and @Nacho Conesa (Nanoide), whereas the handle-type-shape is less important. Putting more information into the graph editor should be done carefully, as too much information will clutter things and make it harder to work with. @Charlie Jolly (charlie): we (@Hjalti Hjálmarsson (hjalti), @Nacho Conesa (Nanoide), and me) are working on a proposal to improve the drawing of these colours in the dope sheet. We'll let you know here when that's online. I don't want to waste your time by asking to include keyframe colour drawing code and then ask you to change it again based on that proposal. Comment Actions @Sybren A. Stüvel (sybren) Thanks for the update. I must have missed the notification. The only note is that the theme colours used in this patch are set in the Dope Sheet space. I'll leave the patch as it is until more decisions are made. Comment Actions @Sybren A. Stüvel (sybren) Should this patch be abandoned now? I'm happy to update it to master otherwise. It is also referred to by this task T70456 |
