Page MenuHome

UI: Remove Some Redundant Colons
ClosedPublic

Authored by Harley Acheson (harley) on Aug 30 2019, 4:20 AM.

Details

Summary

We used to show redundant colons almost everywhere. Inside buttons, after labels, after after headings. But then we removed almost all of them from Properties, then largely banished them from Preferences. This has resulted in a cleaner interface. But we still have some left.

This patch removes one type of them: displayed inside buttons with USE_NUMBUTS_LR_ALIGN alignment.

The following is the one place that you are mostly likely to notice any: In the 3DView Sidebar. Left is how it looks now, right is how it looks after this patch:

The colons are not only unnecessary but also make it more difficult to read quickly.

Another, more interesting, place you might see them is with SMPTE time codes. This format contain colons so the automatic formatting of them results in a superfluous trailing one that is confusing. On the following image, top is how it looks now, below is after this patch is applied:

Diff Detail

Repository
rB Blender

Event Timeline

Although only just realized that the complaints about SMPTE might have been a preference for the last colon but not the space between.
Should have paid more attention. LOL...

The SMPTE thing is fine I think. The frame number is not part of the timecode and there should be a space between.

This revision is now accepted and ready to land.Aug 30 2019, 1:31 PM
This revision was automatically updated to reflect the committed changes.

The SMPTE thing is fine I think. The frame number is not part of the timecode and there should be a space between.

I think its confusing having the SMTPE and frame number displayed at the same time. There's not enough visual separation. I can't
think of any other app that displays both in the same field together. There is usually a way to toggle between one representation and
the other.

And is "frame number" the timeline frame or from the start of the clip?

The design of that is indeed arguable, but it's not related to this code review.

Proposals to change it can be made elsewhere:
https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests