Page MenuHome

WeightPaint Bone Selection Overlay
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Aug 30 2019, 9:40 AM.

Details

Summary

In weightpaint it is possible to enable the bone selection mode. During
drawing the overlay was rendered, but during selection this was ignored.
Users needed to double click in order to select bones even when the overlay
was enabled.

This patch makes bone selection possible during weight painting using the pose mode bone
selection overlay with a single click.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 4678
Build 4678: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Sep 2 2019, 7:34 AM

Running into a bug with inline comments, generally LGTM, a few comments.

  • Short comment on the difference between obedit_ctx_mode & obedit_mode would help.
  • Would prefix object's with ob_, find Object *armature doesn't read well.
  • While OBWEIGHTPAINT_FROM_OBACT is OK, not sure it warrents it's own macro for a single use? (no strong opinion on this if you think it's useful elsewhere).

Tested with T66949: Difficult to select bones for weight paint with multiple armature modifiers, this still requires two clicks when switching between pose objects which are obscured by the geometry.

Although this could even be an advantage (that the active pose gets favored and you can't easily switch to another pose unless it's directly under the cursor).

Just noting it as an issue that users might notice in the future, don't think it's a blocking issue.

Solved code review comments

Seems fine here too. Looks Good To Me!

This revision is now accepted and ready to land.Sep 3 2019, 1:59 PM