Differential D5631

Fix interger number buttons increment/decrement arrows not working in some cases
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Aug 30 2019, 11:14 AM.

Tags

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Group Reviewers

Maniphest Tasks

T69305: Some Integer button increment/decrement arrows are broken (e.g Color Ramp switch arrows don't work)

Commits

rB44ace647a8ec: Fix interger number buttons increment/decrement arrows not working in some cases

Summary

Since rB78b56fa7d973 defining a button with 'but->a1 = 0' wasnt
automatically setting its step value to 1 in 'ui_do_but_NUM' anymore.
Instead of handling this more forgiving in 'ui_do_but_NUM', went over
the remaining cases of buttons and and defined them with a step value of

Fixes T69305

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Aug 30 2019, 11:14 AM

Harbormaster completed remote builds in B4682: Diff 17682.Aug 30 2019, 11:14 AM

Philipp Oeser (lichtwerk) added a reviewer: User Interface.Aug 30 2019, 11:14 AM

Philipp Oeser (lichtwerk) added a project: User Interface.

Brecht Van Lommel (brecht) accepted this revision.Aug 30 2019, 11:50 AM

This revision is now accepted and ready to land.Aug 30 2019, 11:50 AM

Closed by commit rB44ace647a8ec: Fix interger number buttons increment/decrement arrows not working in some cases (authored by Philipp Oeser (lichtwerk)). · Explain WhyAug 30 2019, 12:47 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB44ace647a8ec: Fix interger number buttons increment/decrement arrows not working in some cases.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

animation/

4 lines

interface/

interface_templates.c

4 lines

Diff 17689

source/blender/editors/animation/fmodifier_ui.c

Loading...

source/blender/editors/interface/interface_templates.c

Loading...