Page MenuHome
Differential D5642

Buildbot: refactor all build slave code
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Aug 31 2019, 7:31 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rB283d96de1170: Buildbot: refactor all build slave code
Summary
  • Move common code into buildbot_utils.py
  • Remove legacy code from removed builders
  • Split code into smaller functions

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) created this revision.Aug 31 2019, 7:31 PM
Harbormaster completed remote builds in B4705: Diff 17726.Aug 31 2019, 7:32 PM
Brecht Van Lommel (brecht) added a child revision: D5643: Buildbot: support building releases, make non-releases more consistent.Aug 31 2019, 7:40 PM
Sergey Sharybin (sergey) added inline comments.Sep 1 2019, 10:44 AM
build_files/buildbot/buildbot_utils.py
35–36

What's the difference between those two?

Brecht Van Lommel (brecht) added inline comments.Sep 1 2019, 1:54 PM
build_files/buildbot/buildbot_utils.py
35–36

install_dir is the value for CMAKE_INSTALL_PREFIX, upload_dir is where to put buildbot_upload.zip.

Sergey Sharybin (sergey) added inline comments.Sep 1 2019, 2:49 PM
build_files/buildbot/buildbot_utils.py
35–36

So this is all local, not the directory on the server?

Brecht Van Lommel (brecht) added inline comments.Sep 1 2019, 3:17 PM
build_files/buildbot/buildbot_utils.py
35–36

Yes, these refactored scripts only run on the buildbot slaves.

There should be no functional changes with this patch, it's intended to be purely a code cleanup. The directory layout used on the buildbot slave is the same as before too.

Sergey Sharybin (sergey) accepted this revision.Sep 1 2019, 3:20 PM
This revision is now accepted and ready to land.Sep 1 2019, 3:20 PM
Closed by commit rB283d96de1170: Buildbot: refactor all build slave code (authored by Brecht Van Lommel (brecht)). · Explain WhySep 2 2019, 5:38 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB283d96de1170: Buildbot: refactor all build slave code.

Revision Contents
Changeset List

PathSize
build_files/
buildbot/
92 lines
209 lines
302 lines
24 lines
66 lines
15 lines

Diff 17760

View Options

build_files/buildbot/buildbot_utils.py

Loading...
View Options

build_files/buildbot/slave_compile.py

Loading...
View Options

build_files/buildbot/slave_pack.py

Loading...
View Options

build_files/buildbot/slave_rsync.py

Loading...
View Options

build_files/buildbot/slave_test.py

Loading...
View Options

build_files/buildbot/slave_update.py

Loading...