Buildbot: support building releases, make non-releases more consistent
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Aug 31 2019, 7:34 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Ray Molenkamp (LazyDodo)
Arto Kitula (akitula)

Maniphest Tasks

T67056: Make release builds on buildbot

Commits

rB81849e7c9dcd: Buildbot: support building releases, make non-releases more consistent

Summary

Auto detect rc and release version cycle in BKE_blender_version.h.
On Windows, generate zip and installer if a release is detected.
On macOS, always generate a dmg instead of zip.
Use standard package names without hash if a release is detected.
Buildbot package names now match platform names in releases.

Ref T67056

This needs buildbot server side modifications, and has not been tested on Windows.

Diff Detail

Repository

rB Blender

Branch

buildbot-refactor (branched from master)

Build Status

Buildable 4708
Build 4708: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) planned changes to this revision.Aug 31 2019, 7:34 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B4706: Diff 17727.Aug 31 2019, 7:34 PM

Brecht Van Lommel (brecht) added a parent revision: D5642: Buildbot: refactor all build slave code.Aug 31 2019, 7:40 PM

Brecht Van Lommel (brecht) added a reviewer: Arto Kitula (akitula).Aug 31 2019, 7:46 PM

Fixes

Harbormaster completed remote builds in B4707: Diff 17728.Aug 31 2019, 7:50 PM

Included too much in previous diff.

Harbormaster completed remote builds in B4708: Diff 17729.Aug 31 2019, 7:52 PM

I can't actually test any of this, but it seems fine

we should probably add codesign for windows in this process as well, things we need to sign before packaging are

blender.exe
blenthumb.dll

and once we have the .msi we need to sign that as well.

We can probably generate the windows store package at the same time we make the .zip, although cpack does not support this package format, from some manual testing it
seems that it's just unpacking the .zip, adding a few files (manifest and some bitmaps for UI) and pointing the microsoft packager at the folder, then signing the resulting package.

I have tested this locally with a self signed CA, but never tested it with the store since @Francesco Siddi (fsiddi) kinda went awol on this

I'm unsure what is needed for steam packaging wise.

Seems LGTM. Just when you put all signing keys and account info to mac keychain, you could add those also into slave_pack.py

From reading the change can't spot issues.

As for signing: we should either use dedicated workers for release builds or have signing done as a separate step on a different machine (especially, if there is a plan to compile upcoming differencial revisions).
Either way seems to be just an extra step after this change.

This revision is now accepted and ready to land.Sep 1 2019, 10:59 AM

Closed by commit rB81849e7c9dcd: Buildbot: support building releases, make non-releases more consistent (authored by Brecht Van Lommel (brecht)). · Explain WhySep 3 2019, 12:29 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB81849e7c9dcd: Buildbot: support building releases, make non-releases more consistent.

In D5643#129383, @Ray Molenkamp (LazyDodo) wrote:
I can't actually test any of this, but it seems fine

we should probably add codesign for windows in this process as well, things we need to sign before packaging are
blender.exe
blenthumb.dll
and once we have the .msi we need to sign that as well.

We can probably generate the windows store package at the same time we make the .zip, although cpack does not support this package format, from some manual testing it
seems that it's just unpacking the .zip, adding a few files (manifest and some bitmaps for UI) and pointing the microsoft packager at the folder, then signing the resulting package.

I have tested this locally with a self signed CA, but never tested it with the store since @Francesco Siddi (fsiddi) kinda went awol on this

I'm unsure what is needed for steam packaging wise.