Page MenuHome
Differential D5647

Sculpt: Pose brush
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Sep 1 2019, 12:47 AM.
Tags
None
Subscribers
William Reynish (billreynish)
Tokens
"Love" token, awarded by johnsyed."Love" token, awarded by TheAngerSpecialist."Love" token, awarded by brilliant_ape."Love" token, awarded by CandleComet.

Details

Reviewers
Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)
Commits
rBbfbee8783138: Sculpt: Pose Brush
Summary

This brush lets you pose a model simulating an armature-like deformation. The pivot point for rotation is calculated automatically based on the radius of the brush and the topology of the model.

Diff Detail

Repository
rB Blender
Branch
sculpt-pose-brush (branched from master)
Build Status
Buildable 4855
Build 4855: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Sep 1 2019, 12:47 AM
Harbormaster completed remote builds in B4711: Diff 17733.Sep 1 2019, 12:47 AM
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Sep 1 2019, 12:48 AM
Pablo Dobarro (pablodp606) added reviewers: Campbell Barton (campbellbarton), Brecht Van Lommel (brecht).
CandleComet (CandleComet) awarded a token.Sep 2 2019, 3:21 AM
Ted Nielsen (brilliant_ape) awarded a token.Sep 2 2019, 5:54 PM
Joseph Brandenburg (TheAngerSpecialist) awarded a token.Sep 4 2019, 7:02 PM
Brecht Van Lommel (brecht) requested changes to this revision.Sep 6 2019, 5:59 PM

If you add an icon and solve the issues mentioned in D5645, then I think this is fine.

source/blender/editors/sculpt_paint/sculpt.c
355

This code is shared with D5645, so same comments apply.

3370

Code here is similar to D5645, so same comments apply.

This revision now requires changes to proceed.Sep 6 2019, 5:59 PM
William Reynish (billreynish) added a subscriber: William Reynish (billreynish).Sep 6 2019, 6:07 PM

Same here as with the other tools - will gladly make sure we get an icon in before release.

babajan (johnsyed) awarded a token.Sep 8 2019, 9:10 PM
Pablo Dobarro (pablodp606) updated this revision to Diff 18003.Sep 9 2019, 5:42 PM
  • Rebase
  • Review update
Harbormaster completed remote builds in B4855: Diff 18003.Sep 9 2019, 5:42 PM
Brecht Van Lommel (brecht) accepted this revision.Sep 9 2019, 5:49 PM
This revision is now accepted and ready to land.Sep 9 2019, 5:49 PM
Closed by commit rBbfbee8783138: Sculpt: Pose Brush (authored by Pablo Dobarro (pablodp606)). · Explain WhySep 9 2019, 5:54 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rBbfbee8783138: Sculpt: Pose Brush.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
1 line
editors/
sculpt_paint/
4 lines
284 lines
9 lines
makesdna/
2 lines
makesrna/
intern/
1 line

Diff 18003

View Options

source/blender/blenkernel/intern/brush.c

Loading...
View Options

source/blender/editors/sculpt_paint/paint_stroke.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_intern.h

Loading...
View Options

source/blender/makesdna/DNA_brush_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_brush.c

Loading...