Make gravity UI responsive to change of unit scale
AbandonedPublic
Actions

Authored by Adam Stankiewicz (sheerun) on Sep 2 2019, 6:46 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Summary

Fixes https://developer.blender.org/T52238

This patch makes rna gravity PROP_XYZ instead of PROP_ACCELERATION because it's current physics code uses this value as dimensionless constant. It also adds metric_gravity prop that proxies setting and getting rna gravity in the way that respects currently set unit scale.

Diff Detail

Repository: rB Blender

Event Timeline

Adam Stankiewicz (sheerun) created this revision.Sep 2 2019, 6:46 PM

Thanks for the patch, but this should really be solved at the root in the C code. A Python property to work around the problem is not something we should add.

This revision now requires changes to proceed.Sep 2 2019, 7:18 PM

Do you want to change meaning of DNA field? What is your proposed solution exactly?

The simplest solution could be to change BKE_scene_unit_scale to work for acceleration. I think that would accomplish the same as this patch and only affect the user interface?

Okay bummer. I won't have more time to handle this though.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

properties_scene.py

18 lines

source/

blender/

makesrna/

intern/

rna_scene.c

2 lines

Diff 17761

View Options

release/scripts/startup/bl_ui/properties_scene.py