Page MenuHome
Differential D5674

Viewport Shading: StudioLight Intensity
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Sep 4 2019, 4:23 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Clément Foucault (fclem)
Maniphest Tasks
T67220: Look Dev: Change The Intensity Of The HDRI
Commits
rCfa193be6ce00: Viewport Shading: StudioLight Intensity
rB1b287230a46d: Viewport Shading: StudioLight Intensity
Summary

Add option to change the Intensity of the HDRI in the 3d viewport. This works for both EEVEE and Cycles

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Sep 4 2019, 4:23 PM
Harbormaster completed remote builds in B4759: Diff 17815.Sep 4 2019, 4:23 PM
Jeroen Bakker (jbakker) mentioned this in D5299: Viewport Shading: StudioLight Intensity.Sep 4 2019, 4:23 PM
Jeroen Bakker (jbakker) added reviewers: Brecht Van Lommel (brecht), Clément Foucault (fclem).
Jeroen Bakker (jbakker) added a project: GPU / Viewport.
Brecht Van Lommel (brecht) added inline comments.Sep 4 2019, 4:28 PM
intern/cycles/blender/blender_shader.cpp
1354–1357

Remove this comment and #if 0, fac is indeed the mixing factor and it's the two colors that are multiplied together. That's by design.

Jeroen Bakker (jbakker) updated this revision to Diff 17816.Sep 4 2019, 4:31 PM

Removed comment

Harbormaster completed remote builds in B4760: Diff 17816.Sep 4 2019, 4:31 PM
Jeroen Bakker (jbakker) marked an inline comment as done.Sep 4 2019, 4:31 PM
Brecht Van Lommel (brecht) accepted this revision.Sep 5 2019, 6:32 PM
Clément Foucault (fclem) accepted this revision.Sep 5 2019, 6:51 PM
This revision is now accepted and ready to land.Sep 5 2019, 6:51 PM
Closed by commit rB1b287230a46d: Viewport Shading: StudioLight Intensity (authored by Jeroen Bakker (jbakker)). · Explain WhySep 6 2019, 8:36 AM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB1b287230a46d: Viewport Shading: StudioLight Intensity.
Nathan Letwory (jesterking) added a commit: rCfa193be6ce00: Viewport Shading: StudioLight Intensity.Jan 13 2020, 11:23 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
addon/
1 line
14 lines
1 line
3 lines
release/
scripts/
startup/
bl_ui/
2 lines
source/
blender/
blenkernel/
intern/
1 line
blenloader/
intern/
15 lines
draw/
engines/
eevee/
5 lines
1 line
shaders/
2 lines
makesdna/
4 lines
makesrna/
intern/
11 lines

Diff 17893

View Options

intern/cycles/blender/addon/ui.py

Loading...
View Options

intern/cycles/blender/blender_shader.cpp

Loading...
View Options

intern/cycles/blender/blender_viewport.h

Loading...
View Options

intern/cycles/blender/blender_viewport.cpp

Loading...
View Options

release/scripts/startup/bl_ui/space_view3d.py

Loading...
View Options

source/blender/blenkernel/intern/screen.c

Loading...
View Options

source/blender/blenloader/intern/versioning_280.c

Loading...
View Options

source/blender/draw/engines/eevee/eevee_lookdev.c

Loading...
View Options

source/blender/draw/engines/eevee/eevee_private.h

Loading...
View Options

source/blender/draw/engines/eevee/shaders/default_world_frag.glsl

Loading...
View Options

source/blender/makesdna/DNA_view3d_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...