Details

Reviewers

Commits

rB4e731ec97bd4: Transform: Split transform_conversions into multiple files.

Summary

All functions that start with createTrans... and flushTrans... have been moved to the corresponding data type.
Functions in transform_conversions.c that are exposed in transform.h are now exposed in transform_conversion.h.

Diff Detail

Repository: rB Blender

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Sep 4 2019, 6:16 PM

Harbormaster completed remote builds in B4763: Diff 17821.Sep 4 2019, 6:16 PM

Germano Cavalcante (mano-wii) added a reviewer: Campbell Barton (campbellbarton).Sep 4 2019, 6:18 PM

Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Sep 4 2019, 6:21 PM

Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)

Germano Cavalcante (mano-wii) retitled this revision from Transform: Cleanup: Move Mesh conversion to its own header to Transform: Cleanup: Move Mesh conversion to its own file.Sep 4 2019, 6:23 PM

Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)

Looks good, think these kind of changes could be made in a branch, then committed at once (split up each type into its own file).

Submitted new branch temp-transform-conversions-split

Transform: Move Amrmature conversion to its own file
Transform: Move Cursor Conversion to its own file
Transform: Move Mball conversion to its own file
Transform: Move Curve conversion to its own file
Transform: Move Lattice conversion to its own file
Transform: Expose Tranform conversion utils in its own header
Transform: Move Particle conversion to its own file
Transform: Move Edge and UV conversion to transfom_conversion_mesh
Transform: Move ActionData conversion to its own file
Transform: Move NLA conversion to is own file
Transform: Move graph editor conversion to its own file
Transform: Move Sequencer conversion to its own file
Transform: Move Object conversion to its own file
Transform: Move Texture Space conversion to its transform_conversion_object
Transform: Move node conversion to its own file
Transform: Move Tracking conversion to its own file
Transform: Move Mask conversion to its own file
Transform: Move rush conversion to its own file
Transform: Move Gpencil conversion to its own file
Transform Move each flushTrans... to its respective file.

Harbormaster completed remote builds in B4782: Diff 17863.Sep 5 2019, 3:59 PM

Would call transform_conversions_brush.c > transform_conversions_paintcurve.c, besides this LGTM.

Suggestion, conversions made sense for many, we could call these:

transform_convert_action.c, transform_convert_mesh.c, ... etc.

Germano Cavalcante (mano-wii) retitled this revision from Transform: Cleanup: Move Mesh conversion to its own file to Transform: Split `transform_conversions` into multiples files.Sep 5 2019, 4:47 PM

Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)

Rename transform_conversions_... to transform_convert_...
Rename transform_convert_brush.c > transform_convert_paintcurve.c
Rearrange Header

Harbormaster completed remote builds in B4788: Diff 17877.Sep 5 2019, 7:04 PM

Use capital letters

Harbormaster completed remote builds in B4789: Diff 17879.Sep 5 2019, 7:12 PM

Campbell Barton (campbellbarton) accepted this revision.Sep 5 2019, 7:14 PM

This revision is now accepted and ready to land.Sep 5 2019, 7:14 PM

Closed by commit rB4e731ec97bd4: Transform: Split transform_conversions into multiple files. (authored by Germano Cavalcante (mano-wii)). · Explain WhySep 5 2019, 7:36 PM

This revision was automatically updated to reflect the committed changes.

Germano Cavalcante (mano-wii) added a commit: rB4e731ec97bd4: Transform: Split transform_conversions into multiple files..

Transform: Split `transform_conversions` into multiples files
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 17881

source/blender/editors/transform/CMakeLists.txt

source/blender/editors/transform/transform.h

source/blender/editors/transform/transform.c

source/blender/editors/transform/transform_conversions.c

source/blender/editors/transform/transform_convert.h

source/blender/editors/transform/transform_convert.c

source/blender/editors/transform/transform_convert_action.c

source/blender/editors/transform/transform_convert_armature.c

source/blender/editors/transform/transform_convert_cursor.c

source/blender/editors/transform/transform_convert_curve.c

source/blender/editors/transform/transform_convert_gpencil.c

source/blender/editors/transform/transform_convert_graph.c

source/blender/editors/transform/transform_convert_lattice.c

source/blender/editors/transform/transform_convert_mask.c

source/blender/editors/transform/transform_convert_mball.c

source/blender/editors/transform/transform_convert_mesh.c

source/blender/editors/transform/transform_convert_nla.c

source/blender/editors/transform/transform_convert_node.c

source/blender/editors/transform/transform_convert_object.c

source/blender/editors/transform/transform_convert_paintcurve.c

source/blender/editors/transform/transform_convert_particle.c

source/blender/editors/transform/transform_convert_sequencer.c

source/blender/editors/transform/transform_convert_tracking.c

source/blender/editors/transform/transform_generics.c

source/blender/editors/transform/transform_gizmo_3d.c

source/blender/editors/transform/transform_ops.c

Transform: Split `transform_conversions` into multiples filesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17881

source/blender/editors/transform/CMakeLists.txt

source/blender/editors/transform/transform.h

source/blender/editors/transform/transform.c

source/blender/editors/transform/transform_conversions.c

source/blender/editors/transform/transform_convert.h

source/blender/editors/transform/transform_convert.c

source/blender/editors/transform/transform_convert_action.c

source/blender/editors/transform/transform_convert_armature.c

source/blender/editors/transform/transform_convert_cursor.c

source/blender/editors/transform/transform_convert_curve.c

source/blender/editors/transform/transform_convert_gpencil.c

source/blender/editors/transform/transform_convert_graph.c

source/blender/editors/transform/transform_convert_lattice.c

source/blender/editors/transform/transform_convert_mask.c

source/blender/editors/transform/transform_convert_mball.c

source/blender/editors/transform/transform_convert_mesh.c

source/blender/editors/transform/transform_convert_nla.c

source/blender/editors/transform/transform_convert_node.c

source/blender/editors/transform/transform_convert_object.c

source/blender/editors/transform/transform_convert_paintcurve.c

source/blender/editors/transform/transform_convert_particle.c

source/blender/editors/transform/transform_convert_sequencer.c

source/blender/editors/transform/transform_convert_tracking.c

source/blender/editors/transform/transform_generics.c

source/blender/editors/transform/transform_gizmo_3d.c

source/blender/editors/transform/transform_ops.c

Transform: Split `transform_conversions` into multiples files
ClosedPublic
Actions

Revision Contents
Changeset List