Paths

Table of Contentst

Differential D5699

Fix T69548: Sculpt scene spacing breaks when object pivot not at origin
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Sep 5 2019, 10:20 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Maniphest Tasks

T69548: Sculpt spacing distance set to Scene breaks Space and Line Stroke Methods when object origin is not at world origin

Commits

rB6d8a86c07d5f: Fix T69548: Sculpt scene spacing breaks when object pivot not at origin

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Sep 5 2019, 10:20 PM

Harbormaster completed remote builds in B4792: Diff 17885.Sep 5 2019, 10:20 PM

Pablo Dobarro (pablodp606) added a reviewer: Brecht Van Lommel (brecht).Sep 5 2019, 11:32 PM

Pablo Dobarro (pablodp606) added a task: T69548: Sculpt spacing distance set to Scene breaks Space and Line Stroke Methods when object origin is not at world origin.Sep 6 2019, 12:11 AM

Looks good if you do some renaming.

source/blender/editors/sculpt_paint/paint_stroke.c
542	Can we rename `scene_space_position` to `world_space_position` here and in other places? It's more standard terminology and for me makes it more clear which coordinate space these are in.
635–638	Rename this one to `last_object_space_position`.

This revision is now accepted and ready to land.Sep 6 2019, 2:09 PM

Closed by commit rB6d8a86c07d5f: Fix T69548: Sculpt scene spacing breaks when object pivot not at origin (authored by Pablo Dobarro (pablodp606)). · Explain WhySep 6 2019, 5:19 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB6d8a86c07d5f: Fix T69548: Sculpt scene spacing breaks when object pivot not at origin.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

39 lines

Diff 17911

source/blender/editors/sculpt_paint/paint_stroke.c

Loading...