Page MenuHome
Differential D5715

Build: add "make test" command for Windows
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Sep 7 2019, 6:15 PM.

Details

Reviewers
Ray Molenkamp (LazyDodo)
Commits
rB6472662d6661: Build: add "make test" command for Windows, output log file
Summary

Equivalent of what we have on macOS and Linux.

Diff Detail

Repository
rB Blender
Branch
win-test
Build Status
Buildable 4828
Build 4828: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) created this revision.Sep 7 2019, 6:15 PM
Harbormaster completed remote builds in B4828: Diff 17949.Sep 7 2019, 6:15 PM
Ray Molenkamp (LazyDodo) accepted this revision.Sep 12 2019, 4:59 PM

minor suggestions, but if you commit as is, it's fine

build_files/utils/make_test.py
68

perhaps add a -O Debug/Release_testlog.txt ?

make.bat
66

Perhaps move this after the build so you can build/test in a single invocation?

This revision is now accepted and ready to land.Sep 12 2019, 4:59 PM
Brecht Van Lommel (brecht) added inline comments.Sep 12 2019, 7:53 PM
build_files/utils/make_test.py
68

Will do.

make.bat
66

The problem then is, how do you run just the tests?

I prefer it the way it is now, also for consistency with GNUMakefile. But can see arguments both ways.

Ray Molenkamp (LazyDodo) added inline comments.Sep 12 2019, 7:58 PM
make.bat
66

You'd have to add nobuild to the invocation, which is gonna get annoying real quick, you're right just leave it as is, consistent across platforms and no annoying workarounds to stop it from building when you don't want it.

Closed by commit rB6472662d6661: Build: add "make test" command for Windows, output log file (authored by Brecht Van Lommel (brecht)). · Explain WhySep 12 2019, 8:24 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB6472662d6661: Build: add "make test" command for Windows, output log file.

Revision Contents
Changeset List

PathSize
3 lines
build_files/
utils/
15 lines
windows/
4 lines
3 lines
1 line
1 line
13 lines
5 lines

Diff 17949

View Options

GNUmakefile

Loading...
View Options

build_files/utils/make_test.py

Loading...
View Options

build_files/windows/find_dependencies.cmd

Loading...
View Options

build_files/windows/parse_arguments.cmd

Loading...
View Options

build_files/windows/reset_variables.cmd

Loading...
View Options

build_files/windows/show_help.cmd

Loading...
View Options

build_files/windows/test.cmd

Loading...
View Options

make.bat

Loading...