Transform tool from the sculpt branch
I removed the "move pivot only" option and I added scaling support.
This patch has some code copied from D5513 to make it work. All bugs related to viewport or shape key updates should be solved after merging that and rebasing.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- sculpt-transform-tool (branched from master)
- Build Status
Buildable 4864 Build 4864: arc lint + arc unit
Event Timeline
Comment Actions
The code that's here seems generally fine, but didn't test due to the missing file.
| source/blender/editors/sculpt_paint/sculpt.c | ||
|---|---|---|
| 8712 | paintSymmAreas -> PaintSymmetryAreas | |
| source/blender/editors/sculpt_paint/sculpt.c | ||
|---|---|---|
| 8617 | /home/brecht/dev/blender/source/blender/editors/sculpt_paint/sculpt.c: In function ‘sculpt_get_vertex_symm_area’:
/home/brecht/dev/blender/source/blender/editors/sculpt_paint/sculpt.c:8617:56: warning: unused parameter ‘ss’ [-Wunused-parameter]
static char sculpt_get_vertex_symm_area(SculptSession *ss, float co[3], float pivot[3])
^~
/home/brecht/dev/blender/source/blender/editors/sculpt_paint/sculpt.c:8617:79: warning: unused parameter ‘pivot’ [-Wunused-parameter]
static char sculpt_get_vertex_symm_area(SculptSession *ss, float co[3], float pivot[3])
^~~~~ | |
| 8700 | The code here could use some comments explaining what the various steps do. These are quite expensive operations to do for every vertex. Is it possible to precompute a transfrom matrix for every symm_area value, and then use that? | |
Comment Actions
Just one more comment, which I guess you can easily resolve and commit directly.
| source/blender/editors/sculpt_paint/sculpt.c | ||
|---|---|---|
| 8708–8710 | If you multiply these 3 matrices together in advance, you only need to do a single matrix multiplication per vertex. | |