EditMesh support mirror on all axes
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Sep 9 2019, 5:14 AM.

Details

Reviewers

Campbell Barton (campbellbarton)

Commits

rB3bd4f229beb1: Transform: Edit Mesh: Support mirror on all axes

Summary

Part of T68930

This patch adds two more mirror options that can be enabled simultaneously: Mirror Y and Z.

Since different transformation options use their own mirroring code (eg edge / vert slide and proportional editing), this patch proposes a generic solution that can be applied to any transformation.

The idea is to create a new array type that points to the location of each reference element with the mirror element location.

This reduces the amount of TransData that is already overkill.

Diff Detail

Repository: rB Blender

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Sep 9 2019, 5:14 AM

Harbormaster completed remote builds in B4837: Diff 17968.Sep 9 2019, 5:14 AM

Asher (ThatAsherGuy) added a subscriber: Asher (ThatAsherGuy).Sep 9 2019, 5:32 AM

Cleanup: Use more descriptive variable names

Harbormaster completed remote builds in B4851: Diff 17997.Sep 9 2019, 5:11 PM

Generally looks good.

Only concern with this is it removes UV correction for vert/edge slide.

slide_correct.blend588 KBDownload

This is something I was considering we could generalize anyway, since it would be useful to be able to move any vertex and have UV's and vertex colors be corrected.

Added a task for this T69707: Transform generalized custom-data correction support.

Note that only part of this proposal would need to be implemented to handle the case of vertex/edge slide. Projecting onto original geometry could be postponed.

Campbell Barton (campbellbarton) requested changes to this revision.Sep 10 2019, 1:03 PM

Campbell Barton (campbellbarton) added inline comments.

source/blender/editors/transform/transform.h
421–424	Think it would be more clear to call `loc_src`, `loc_dst`.
425	Would store this as a flag, since multiplying a float by a short isn't all that efficient.
533–539	Can see how this reads nicely but think this could be a flag too. Since it fits better in a loop and there is some risk the `axis_flag` gets used in a way that breaks depending on the order of the bit-field. See: https://stackoverflow.com/a/1490142/432509

This revision now requires changes to proceed.Sep 10 2019, 1:03 PM

Cleanup: Use more descriptive variable names;
Rename TransDataMirror members and use bitfield for sign;
Move all CustomData correction logic used on Edge/Vert Slide to transform_convert_mesh.c.