Differential D5740

EEVEE: Volume: Speedup: Use Image load store extension
ClosedPublic
Actions

Authored by Clément Foucault (fclem) on Sep 10 2019, 2:18 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rBcaf494444cd7: EEVEE: Volume: Speedup: Use Image load store extension

Summary

This reduces considerably the time spent for the integration
phase:

Volumetric pass only on Intel HD 4600: 54ms -> 14ms

Diff Detail

Repository: rB Blender

Event Timeline

Clément Foucault (fclem) created this revision.Sep 10 2019, 2:18 PM

Harbormaster completed remote builds in B4871: Diff 18034.Sep 10 2019, 2:18 PM

Sounds great.

I am getting some test failures (with Quadro RTX 5000 on Ubuntu). There are a dozen or so tests already failing in master, I'm not sure if those are platform specific differences or if you see the same thing.

But ignoring those, with this patch volumes look quite a bit denser too. The result looks more accurate, for example in the "principled blackbody" test the volume is now properly appearing in front of the sphere as dense as Cycles.

I'm not sure if that indicates a bug in the non-optimized code, or if it's intentional the optimized code is more accurate as well?

This revision is now accepted and ready to land.Sep 10 2019, 4:08 PM

noki paike (amonpaike) awarded a token.Sep 10 2019, 4:25 PM

In D5740#132004, @Brecht Van Lommel (brecht) wrote:

I'm not sure if that indicates a bug in the non-optimized code, or if it's intentional the optimized code is more accurate as well?

OMG that's spot on! This was an off by one error in the previous code. Fix will be committed separately.

Closed by commit rBcaf494444cd7: EEVEE: Volume: Speedup: Use Image load store extension (authored by Clément Foucault (fclem)). · Explain WhySep 10 2019, 10:00 PM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rBcaf494444cd7: EEVEE: Volume: Speedup: Use Image load store extension.