Details

Reviewers

Maniphest Tasks

T61797: Cycles ignores 'Local View' mode during Prreview

Commits

rCde49f281811b: Initial support for local view
rB861697c9e55b: Cycles: Initial Support For Local View

Summary

This diff will add support for local view to Cycles rendered preview mode.

Currently the implementation shows same results as EEVEE does. This means there is a difference with Blender 2.79, where lights were automatically added to the local view. T69780: Local/Global View handles light differently between Blender 2.79 and Blender 2.80 describes this should be solved before the next release.

This patch also solves missing owner_id issues when using the RNA CPP Api from Cycles. Cycles didn't provide the owner_id making some functionality fail, what then was worked around in Blender. It also fixes an issue in makesrna where incorrect CPP code was generated when only PARM_RNAPTR was provided.

An optional view_layer parameter is added to the Object.local_view_get method to reduce lookups.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Sep 11 2019, 11:46 AM

Harbormaster completed remote builds in B4899: Diff 18087.Sep 11 2019, 11:46 AM

Cleanup

Harbormaster completed remote builds in B4900: Diff 18088.Sep 11 2019, 11:52 AM

Comments

Harbormaster completed remote builds in B4901: Diff 18089.Sep 11 2019, 12:14 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Sep 11 2019, 12:15 PM

Jeroen Bakker (jbakker) added a reviewer: Brecht Van Lommel (brecht).

Jeroen Bakker (jbakker) added a project: Render & Cycles.

Ludvik Koutny (rawalanche) awarded a token.Sep 11 2019, 3:32 PM

Jeroen Bakker (jbakker) planned changes to this revision.Sep 11 2019, 4:20 PM

Jeroen Bakker (jbakker) added inline comments.

source/blender/makesrna/intern/rna_object_api.c
258	`blender_python.cpp` seems to be the reason, not the CPP API. PointerRNA v3dptr; RNA_pointer_create(NULL, &RNA_SpaceView3D, pylong_as_voidptr_typesafe(pyv3d), &v3dptr); BL::SpaceView3D v3d(v3dptr); The first NULL is the reference to the ID datablock where the SpaceView3D is part of. As cycles set it to NULL some parts of the API needs to take some counter measurements. I have also seen this when working on the Viewport Render Parameters. Will update the patch so BlenderPython also receives the Appropriate Screen. And update the documentation.