Fix T59143: Frame Selected Doesn't work in hair particle editmode
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 11 2019, 3:01 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Maniphest Tasks

T59143: Frame Selected Doesn't work in Particle edit Mode (hair)

Commits

rB7e245e482ca6: Fix T59143: Frame Selected Doesn't work in hair particle editmode

Summary

This is caused by rBeb521b22b2b1.

Looks like PE_minmax doesnt play nice with the evaluated view_layer.
Why? If we look inside PE_get_current, then
BKE_ptcache_ids_from_object will actually return a list of PTCacheID
for the evaluated object.
However, looking further, then PTCacheEdit / psys->pointcache->edit
is always NULL for the evaluated object.
I assume this only lives on the original?

Without a valid PTCacheEdit, PE_minmax will basically do nothing.
Suggest to pass the non-evaluated view layer in the case of particles
instead?

Diff Detail

Repository

rB Blender

Branch

T59143 (branched from master)

Build Status

Buildable 4908
Build 4908: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Sep 11 2019, 3:01 PM

Harbormaster completed remote builds in B4908: Diff 18100.Sep 11 2019, 3:01 PM

This is probably fine, since brush_edit_init() is using original view layer as well.

In a longer term we should probably make it so evaluated pointcache have pointer to edit. AFAIR, this is what psys_eval does as well.

This revision is now accepted and ready to land.Sep 11 2019, 4:06 PM

Closed by commit rB7e245e482ca6: Fix T59143: Frame Selected Doesn't work in hair particle editmode (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 11 2019, 6:05 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB7e245e482ca6: Fix T59143: Frame Selected Doesn't work in hair particle editmode.

Philipp Oeser (lichtwerk) mentioned this in D5755: Fix T68645: Hair Particle Edit - Particle Mirror crash when children are visible in the viewport.Sep 11 2019, 9:31 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_view3d/

view3d_edit.c

2 lines

Diff 18100

View Options

source/blender/editors/space_view3d/view3d_edit.c

Fix T59143: Frame Selected Doesn't work in hair particle editmodeClosedPublicActions