Page MenuHome
Differential D5785

GPencil simplify modifier sample mode fixes
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on Sep 13 2019, 3:09 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
Maniphest Tasks
T69829: Grease pencil simplify modifier crashes blender in sample mode
Summary

This patch fixes sample mode for simplify modifier.

Problem is caused by:

  • Incorrect count during original weight list reading.
  • Didn't free the original weight list while attaching the new one.

Diff Detail

Event Timeline

YimingWu (NicksBest) created this revision.Sep 13 2019, 3:09 PM
YimingWu (NicksBest) added a task: T69829: Grease pencil simplify modifier crashes blender in sample mode.
Antonio Vazquez (antoniov) accepted this revision.Sep 13 2019, 3:40 PM

I have tested and fix the problems.

Be sure to review the blanks at the end in 1741 and the comment of 1735 maybe would be better as "Free original weight data."

This revision is now accepted and ready to land.Sep 13 2019, 3:40 PM
YimingWu (NicksBest) closed this revision.Sep 13 2019, 3:44 PM

Committed into master.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
10 lines

Diff 18199

View Options

source/blender/blenkernel/intern/gpencil.c

Loading...