Page MenuHome
Differential D5801

Fix typos in source API
ClosedPublic
Actions

Authored by luzpaz (luzpaz) on Sep 15 2019, 9:42 AM.

Details

Reviewers
Brendon Murphy (meta-androcto)
Brecht Van Lommel (brecht)
Commits
rBAd68dca98ce67: Cleanup: fix typos in source code
rBAb1cec919ec7d: Cleanup: fix types in source code
Summary

These changes need closer review.

Diff Detail

Event Timeline

luzpaz (luzpaz) created this revision.Sep 15 2019, 9:42 AM
Jacques Lucke (JacquesLucke) edited reviewers, added: Brendon Murphy (meta-androcto); removed: Brecht Van Lommel (brecht).Sep 20 2019, 1:49 PM
Brecht Van Lommel (brecht) requested changes to this revision.Sep 23 2019, 7:12 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).
Brecht Van Lommel (brecht) added inline comments.
io_scene_fbx/export_fbx_bin.py
300

This spelling error is actually part of the file format, and should not be fixed.
https://help.autodesk.com/view/FBX/2016/ENU/?guid=__cpp_ref_class_fbx_camera_html

This revision now requires changes to proceed.Sep 23 2019, 7:12 PM
luzpaz (luzpaz) updated this revision to Diff 44750.Nov 15 2021, 9:39 AM

rebased, removed previous offending upstream change, added more API typos

luzpaz (luzpaz) mentioned this in D13218: Cleanup: fix various typos.Nov 15 2021, 9:45 AM
luzpaz (luzpaz) marked an inline comment as done.Dec 4 2021, 1:39 AM

Sorry folks, having problems rebasing this patch and removing the offending commit

io_scene_fbx/export_fbx_bin.py
300

@Brecht Van Lommel (brecht) should I rebase, revert the typo and then resubmit the patch ?

300

Sorry folks for the delay on this. I had to revamp my blender clone and lost the patch info. Trying to redownload the patch and git apply it is not working. Can someone remove the offending code above, and rebase the patch?

luzpaz (luzpaz) updated this revision to Diff 45621.Dec 4 2021, 1:46 AM
luzpaz (luzpaz) marked an inline comment as done.

Rebased and fixed any pending requests

Brecht Van Lommel (brecht) accepted this revision.Jan 5 2022, 3:31 PM
This revision is now accepted and ready to land.Jan 5 2022, 3:31 PM
Closed by commit rBAb1cec919ec7d: Cleanup: fix types in source code (authored by Brecht Van Lommel (brecht)). · Explain WhyJan 5 2022, 3:47 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBAb1cec919ec7d: Cleanup: fix types in source code.
Brecht Van Lommel (brecht) added a commit: rBAd68dca98ce67: Cleanup: fix typos in source code.

Revision Contents
Changeset List

PathSize
archipack/
18 lines
4 lines
2 lines
2 lines
2 lines
38 lines
6 lines
2 lines
blenderkit/
6 lines
4 lines
6 lines
curve_tools/
82 lines
io_scene_fbx/
2 lines
materials_utils/
2 lines
6 lines
mesh_snap_utilities_line/
2 lines
2 lines

Diff 18238

View Options

archipack/archipack_2d.py

Loading...
View Options

archipack/archipack_cutter.py

Loading...
View Options

archipack/archipack_floor.py

Loading...
View Options

archipack/archipack_gl.py

Loading...
View Options

archipack/archipack_manipulator.py

Loading...
View Options

archipack/archipack_roof.py

Loading...
View Options

archipack/archipack_stair.py

Loading...
View Options

archipack/archipack_wall2.py

Loading...
View Options

blenderkit/bkit_oauth.py

Loading...
View Options

blenderkit/ui.py

Loading...
View Options

blenderkit/ui_panels.py

Loading...
View Options

curve_tools/internal.py

Loading...
View Options

io_scene_fbx/export_fbx_bin.py

Loading...
View Options

materials_utils/__init__.py

Loading...
View Options

mesh_f2.py

Loading...
View Options

mesh_snap_utilities_line/common_classes.py

Loading...
View Options

mesh_snap_utilities_line/op_line.py

Loading...