Page MenuHome
Differential D5818

Sculpt: Split original normal into original normal and plane
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Sep 16 2019, 6:41 PM.
Tags
None
Subscribers
Julien Kaspar (JulienKaspar)
Tokens
"100" token, awarded by Frozen_Death_Knight."Love" token, awarded by xrg."Love" token, awarded by JulienKaspar.

Details

Reviewers
Jeroen Bakker (jbakker)
Commits
rB04843d1572fe: Sculpt: Split original normal into original normal and plane
Summary

This allows to create different effects with some brushes that use the sculpt plane

Diff Detail

Repository
rB Blender
Branch
sculpt-original-plane (branched from master)
Build Status
Buildable 4992
Build 4992: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Sep 16 2019, 6:41 PM
Harbormaster completed remote builds in B4981: Diff 18272.Sep 16 2019, 6:41 PM
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Sep 16 2019, 6:44 PM
Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).
Pablo Dobarro (pablodp606) added a subscriber: Julien Kaspar (JulienKaspar).
Julien Kaspar (JulienKaspar) awarded a token.Sep 16 2019, 6:48 PM
xrg (xrg) awarded a token.Sep 16 2019, 7:04 PM
Jeroen Bakker (jbakker) requested changes to this revision.Sep 17 2019, 9:19 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/blenloader/intern/versioning_270.c
1749–1750

First thought was to not reuse old flags, but these flags have been unset already since a long time.
So current implementation is acceptable as long as we comment the do_versioning part.

It is currently unclear what these flags have to do with falloff_angle.

Note: We could free some flags by moving the pressure flags from eBrushFlags to BrushMaskPressureFlags, but that will break file compatibility, that can be avoided by introducing more space in a separate flag.

source/blender/editors/sculpt_paint/sculpt.c
4288–4293

Seems like we could limit a copy.

if ((!ss->cache->first_time) && (brush->flag & BRUSH_ORIGINAL_NORMAL)) {
} else {
}
4296–4301

Same here

This revision now requires changes to proceed.Sep 17 2019, 9:19 AM
Pablo Dobarro (pablodp606) updated this revision to Diff 18295.Sep 17 2019, 4:05 PM
Pablo Dobarro (pablodp606) marked 3 inline comments as done.
  • Review update
Harbormaster completed remote builds in B4992: Diff 18295.Sep 17 2019, 4:05 PM
Jeroen Bakker (jbakker) accepted this revision.Sep 18 2019, 8:14 AM
This revision is now accepted and ready to land.Sep 18 2019, 8:14 AM
Closed by commit rB04843d1572fe: Sculpt: Split original normal into original normal and plane (authored by Pablo Dobarro (pablodp606)). · Explain WhySep 18 2019, 4:33 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rB04843d1572fe: Sculpt: Split original normal into original normal and plane.
Kenn Nyström (Frozen_Death_Knight) awarded a token.Sep 18 2019, 7:08 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
1 line
source/
blender/
blenloader/
intern/
3 lines
editors/
sculpt_paint/
17 lines
makesdna/
2 lines
makesrna/
intern/
8 lines

Diff 18295

View Options

release/scripts/startup/bl_ui/space_view3d_toolbar.py

Loading...
View Options

source/blender/blenloader/intern/versioning_270.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt.c

Loading...
View Options

source/blender/makesdna/DNA_brush_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_brush.c

Loading...