Page MenuHome
Differential D5830

UI: use consistent names for blend modes
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Sep 17 2019, 9:56 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
William Reynish (billreynish)
Commits
rB97ba7f3c322a: UI: use consistent names and menu organization for blending modes
Summary

Use consistent names for blend modes:

  • "Blending Mode"
  • "Color Dodge"
  • "Linear Dodge (Add)" "Add"
  • "Luminosity" "Value"

https://devtalk.blender.org/t/blend-modes-naming-inconsistency/8006
https://developer.blender.org/D5186

Diff Detail

Repository
rB Blender

Event Timeline

Yevgeny Makarov (jenkm) created this revision.Sep 17 2019, 9:56 PM
Jacques Lucke (JacquesLucke) added a reviewer: William Reynish (billreynish).Sep 20 2019, 1:34 PM
Brecht Van Lommel (brecht) requested changes to this revision.Sep 23 2019, 6:44 PM
  • "Linear Dodge": name this "Add", no need to be consistent with odd naming in painting apps when these blend modes are used for shading and other purposes, where this is not a standard name and it only adds confusion.
  • "Luminosity": name this "Value" so it's clear this is about the third component of HSV.
This revision now requires changes to proceed.Sep 23 2019, 6:44 PM
Yevgeny Makarov (jenkm) updated this revision to Diff 18427.Sep 23 2019, 7:52 PM
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)

"Linear Dodge" -> "Add"
"Luminosity" -> "Value"

Brecht Van Lommel (brecht) accepted this revision.Oct 2 2019, 1:03 PM
This revision is now accepted and ready to land.Oct 2 2019, 1:03 PM
Closed by commit rB97ba7f3c322a: UI: use consistent names and menu organization for blending modes (authored by Yevgeny Makarov (jenkm), committed by Brecht Van Lommel (brecht)). · Explain WhyOct 2 2019, 1:04 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB97ba7f3c322a: UI: use consistent names and menu organization for blending modes.

Revision Contents
Changeset List

PathSize
source/
blender/
makesrna/
intern/
66 lines
2 lines
2 lines
32 lines

Diff 18714

View Options

source/blender/makesrna/intern/rna_brush.c

Loading...
View Options

source/blender/makesrna/intern/rna_material.c

Loading...
View Options

source/blender/makesrna/intern/rna_nodetree.c

Loading...
View Options

source/blender/makesrna/intern/rna_sequencer.c

Loading...