Fix T70020: Sculpt mode transform tools fail with cursor orientation
Needs RevisionPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Sep 18 2019, 7:33 PM.

Details

Reviewers

Germano Cavalcante (mano-wii)
Jeroen Bakker (jbakker)

Maniphest Tasks

T70020: Sculpt mode transform tools. Weirdness with 3d cursor.

Diff Detail

Repository

rB Blender

Branch

T70020 (branched from master)

Build Status

Buildable 5022
Build 5022: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Sep 18 2019, 7:33 PM

Harbormaster completed remote builds in B5022: Diff 18344.Sep 18 2019, 7:33 PM

Pablo Dobarro (pablodp606) added reviewers: Germano Cavalcante (mano-wii), Jeroen Bakker (jbakker).Sep 18 2019, 7:34 PM

Overall looks good. Just a few lines worry me.

source/blender/editors/transform/transform_gizmo_3d.c
1192	Does this line have the possibility to be executed with `t->options & CTX_PAINT_CURVE`? If so, would that be a bug?
1202	Same as above

Jeroen Bakker (jbakker) added inline comments.Sep 19 2019, 11:39 AM

source/blender/editors/transform/transform_gizmo_3d.c
1176	Add `ob` check similar to below.

Jeroen Bakker (jbakker) requested changes to this revision.Sep 19 2019, 11:39 AM

This revision now requires changes to proceed.Sep 19 2019, 11:39 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

transform/

transform_convert_sculpt.c

12 lines

transform_gizmo_3d.c

21 lines

Diff 18344

View Options

source/blender/editors/transform/transform_convert_sculpt.c