Page MenuHome

Reworked the patch according to Campbell's proposal.
AbandonedPublic

Authored by Gaia Clary (gaiaclary) on Jun 7 2014, 5:41 PM.

Diff Detail

Branch
arcpatch-D390

Event Timeline

Gaia Clary (gaiaclary) updated this revision to Unknown Object (????).Jun 8 2014, 12:38 AM

Also added support for the themable unreferenced verts color

source/blender/blenkernel/intern/editderivedmesh.c
346–347

I don't think this block of code is needed at all, setDrawInterpOptions can be used to set the color to use weights, This will also make drawing work with modifiers (subsurf in edimode for eg)

The way this would work is the caller has to check if weights are used and pass a different setDrawInterpOptions function in that case.

Campbell Barton (campbellbarton) requested changes to this revision.Jun 9 2014, 5:24 AM
Gaia Clary (gaiaclary) updated this revision to Unknown Object (????).Jun 18 2014, 1:56 AM

Added modifications as proposed by Campbel (still WIP)

Gaia Clary (gaiaclary) updated this revision to Unknown Object (????).Jun 18 2014, 2:09 AM

Cleaned up some obsolete statements

Gaia Clary (gaiaclary) updated this revision to Unknown Object (????).Jun 18 2014, 2:41 AM

Improved Display with Matcap and Display in Solid Mode

@Campbell Barton (campbellbarton) I modified the patch according to your recommendations. Someone mentioned it would be good to not colorize edges when we are in solid mode. I think i solved this by now. I also added display of weighted wireframes when Matcap is enabled. I am not sure if this is useful, but it looks nice :) see

source/blender/blenkernel/intern/DerivedMesh.c
1077 ↗(On Diff #1942)

All these can be removed, just pass via the callback data

source/blender/blenkernel/intern/editderivedmesh.c
49

this file can be unchanged

source/blender/editors/space_view3d/drawobject.c
155

result of DM_get_weight_user() can go here too.

2445

This is incorrect, It should interpolate between the 2 colors if its not 0.0 or 1.0. As selection does.

You should be able to check this is working with subsurf+cage.

source/blender/editors/space_view3d/drawobject.c
2419

The mesh either has deform weights or not. This check should be moved into draw_dm_edges_sel_interp or even earlier.

Gaia Clary (gaiaclary) updated this revision to Unknown Object (????).Jun 18 2014, 5:44 PM
  • Removed all changes fro editderivedmesh.c
  • added unweighted verts color to the custom data structure
  • interpolation of weight colors (take care of the t factor)
Gaia Clary (gaiaclary) updated this revision to Unknown Object (????).Jun 18 2014, 7:02 PM

removed obsolete lines of code.

This patch was committed with some improvements (not shown here)