Outliner: Use general update methods for syncing
AbandonedPublic
Actions

Authored by Nathan Craddock (natecraddock) on Sep 20 2019, 11:52 PM.

Details

Reviewers

Summary

As discussed in T69212: Outliner Sync Selection: Use general update method, after selection changes, 3 function calls need to be made to tag despgraph, notifiers, and outliner for syncing. This adds two functions, ED_object_select_update and ED_sequencer_select_update to simplify operator code.

This will also be extended to edit bones and pose bones.

Diff Detail

Repository

rB Blender

Branch

temp-outliner-sync-general-update (branched from master)

Build Status

Buildable 5053
Build 5053: arc lint + arc unit

Event Timeline

Nathan Craddock (natecraddock) created this revision.Sep 20 2019, 11:52 PM

Harbormaster completed remote builds in B5053: Diff 18393.Sep 20 2019, 11:52 PM

Nathan Craddock (natecraddock) edited the summary of this revision. (Show Details)Sep 20 2019, 11:55 PM

Nathan Craddock (natecraddock) added a reviewer: Campbell Barton (campbellbarton).

Nathan Craddock (natecraddock) added inline comments.Sep 20 2019, 11:58 PM

source/blender/editors/object/object_add.c
2672	I'm not sure if it was safe to remove the `ID_RECALC_SELECT` from the first depsgraph tag, but it was redundant in `ED_object_select_update`
source/blender/editors/space_view3d/view3d_select.c
1290	The file `view3d_select.c` did not have the 3 function calls grouped together, so I'm not sure how this should best be approached. I replaced the synced selection tagging with `ED_object_select_update`