Page MenuHome

UI: Add an Outline to the Popover Arrows
ClosedPublic

Authored by Yevgeny Makarov (jenkm) on Sep 23 2019, 9:08 AM.
Tokens
"Like" token, awarded by jc4d."Like" token, awarded by amonpaike."Love" token, awarded by jonathanl."Love" token, awarded by harley."Love" token, awarded by billreynish.

Diff Detail

Repository
rB Blender

Event Timeline

This revision is now accepted and ready to land.Jan 7 2020, 4:25 PM
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)

New implementation with anti-aliasing.

NOTE: This also requires updating the Dark Theme, since it doesn't have a fully opaque menu background right now.
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)

trying to improve the comments

I'm not sure removing the opacity of the popover is desirable. Maybe a better option would be to modify the drawing to not draw on the arrow twice. like using the depth or stencil buffer.

If the rendering is happening in an offscreen buffer (i dont remember if thas the case for popover), another option would be to draw a rect without blending but with 0 opacity to do a partial clear of the area where the arrow is.

Clément Foucault (fclem) requested changes to this revision.Mar 12 2020, 2:39 PM
This revision now requires changes to proceed.Mar 12 2020, 2:39 PM
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)

revert to a simpler version without anti-aliasing

note, there is currently an arrow bug:
https://developer.blender.org/T65351#889095

The aliasing does not seems to be a problem to me. I cannot see it since the triangle is not in motion.

We could avoid the clearing triangle by modifying the blend equation (GPU_blend_set_func_separate(GPU_SRC_ALPHA, GPU_ZERO, GPU_ONE, GPU_ZERO);) but I don't want to make the drawing more complex than it is.

This revision is now accepted and ready to land.Mar 15 2020, 11:14 PM