Text Editor: Add smooth scrolling
AbandonedPublic
Actions

Authored by Kai Jægersen (kaio) on Sep 23 2019, 4:33 PM.

Details

Reviewers

Julian Eisel (Severin)
Campbell Barton (campbellbarton)

Group Reviewers

Text Editor

Summary

This patch makes it so text in the text editor may be smooth scrolled.

Works by making st->top, st->left as floats, then calculate draw offsets and adding them to the draw coordinates.

This patch makes some changes in draw order so that text may be scrolled horizontally behind line numbers margin.

Does not change the behavior of scroll operators which use fixed values, e.g a mouse wheel still scrolls three lines. However drag scrolling (middle mouse pan, text scroll bar) now applies delta directly to st->top and st->left without being accumulated.

Also added behavior to reveal line when setting cursor on a partially visible line.

Diff Detail

Event Timeline

Kai Jægersen (kaio) created this revision.Sep 23 2019, 4:33 PM

Colin Basnett (cmbasnett) awarded a token.Sep 23 2019, 8:44 PM

Peter Fog (tintwotin) awarded a token.Sep 24 2019, 11:09 AM

arindam (Arindam) awarded a token.Sep 24 2019, 3:23 PM

Fin O'Riordan (fin.eskimo) awarded a token.Sep 24 2019, 4:09 PM

Bartosz Moniewski (monio) awarded a token.Sep 24 2019, 4:32 PM

Pablo Dobarro (pablodp606) awarded a token.Sep 24 2019, 4:35 PM

-- (zgorg) awarded a token.Sep 24 2019, 4:50 PM

This comment has been deleted.

Julian Eisel (Severin) added a reviewer: Julian Eisel (Severin).Sep 24 2019, 5:10 PM

lucas veber (lucky3) awarded a token.Sep 24 2019, 5:33 PM

Samir Osman (Samirosman) awarded a token.Sep 24 2019, 6:37 PM

Ted Nielsen (brilliant_ape) awarded a token.Sep 24 2019, 6:47 PM

Bataev Artem (shader) awarded a token.Sep 24 2019, 10:09 PM

babajan (johnsyed) awarded a token.Sep 24 2019, 11:30 PM

Would this make sense in other 2D editors also? e.g. the Outliner and properties?

@Aaron Carlisle (Blendify) From what I gathered, most 2d editors already share a common pan and scroll operator which on paper does support by-pixel scrolling. The text editor is a bit of an oddball here, being one of the last editors that still uses fixed line scrolling. There were some remarks in the code about it being left out, but no explanation as to why.

If you meant in terms of smooth animated scrolling using the mousewheel, it's not being tackled this round, however I'd be keen on trying to add support for this (and yes, I think it would be a nice, toggleable feature to have).

noki paike (amonpaike) awarded a token.Sep 29 2019, 1:46 AM

Diego Gangl (januz) mentioned this in D1708: Add smooth scrolling to text editor.Oct 2 2019, 1:37 AM

Paul R (intracube) awarded a token.Oct 15 2019, 10:09 PM

Vitalii Vlasov (Fracture128) awarded a token.Oct 16 2019, 8:07 PM

@Campbell Barton (campbellbarton) ?

Basic smooth scrolling could be supported for transitions.

Middle mouse panning could use existing smooth offset, rounding it once the operators finished.

Suggest look into VIEW2D_OT_smoothview, the text editor could use something like this for page up/down, scroll-wheel, centering the view.

This would give the pleasant experience of smooth transitions, without having to support floating point scrolling for all other interactions.

Note that full smooth scrolling support isn't a bad feature, I just rather avoid having to support it for all operators since it adds some maintenance overhead.

This revision now requires changes to proceed.Nov 22 2019, 10:09 AM

Andres Stephens (Draise) awarded a token.Nov 23 2019, 4:55 PM

Andrea Monzini (Andrea_Monzini) awarded a token.Nov 23 2019, 6:28 PM

I looked into this and ended up committing a simpler implementation that's only active while scrolling.

rB3106ca8f6397: Text Editor: smooth scrolling.