WIP: Support UV coordinates in CCG path of multires
Needs ReviewPublic
Actions

Authored by Sergey Sharybin (sergey) on Sep 24 2019, 12:09 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Clément Foucault (fclem)

Maniphest Tasks

T63581: Textures not displayed in sculpt mode due to missing UVs (PBVH rendering, Multires)

Summary

Store UVs in a loop custom data where indexing is done in a
grid element manner. This allows to extend attributes further
to support vertex colors as well.

Currently only default UV layer is sent to GPU.
This is something where i would hope to have help from Clement :)

Fixes T63581: Multires: textures not displayed in sculpt mode

Diff Detail

Repository

rB Blender

Branch

multires_ccg_uv_v2 (branched from master)

Build Status

Buildable 5071
Build 5071: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) created this revision.Sep 24 2019, 12:09 PM

Harbormaster completed remote builds in B5071: Diff 18447.Sep 24 2019, 12:09 PM

Another note: only works with flat shading. Smooth shading should be starightforward as well, but first would be nice to know if the approach is good in general and that we can indeed do all the required attributes from GPU_pbvh_grid_buffers_update().

noki paike (amonpaike) awarded a token.Sep 26 2019, 4:09 PM

Currently only default UV layer is sent to GPU.
This is something where i would hope to have help from Clement :)

All you need is to mimic what happens in extract_uv_init for the GPUVertFormat creation.

The other issue then is how to pass the GPUMaterials to get the needed layers. Computing the needed layer could be done in DRW and only pass the layer list to the buffer update function.

The patch looks fine for the areas that concerns me.

source/blender/gpu/intern/gpu_buffers.c
138	unrelated to this patch but add alias to "c"
139	add alias to "au"

This revision is now accepted and ready to land.Mar 23 2020, 9:35 PM

Sergey Sharybin (sergey) added inline comments.Mar 24 2020, 11:25 AM

source/blender/gpu/intern/gpu_buffers.c
138	Unrelated to the degree that can just be ignored "for now" ? What is alias, how to add it and what is "c" ?
139	What is "au" ?

Clément Foucault (fclem) added inline comments.Mar 24 2020, 2:54 PM

source/blender/gpu/intern/gpu_buffers.c
138	what is "c" ? same as `u` Unrelated to the degree that can just be ignored "for now" ? Doesn't hurt to add it. What is alias, how to add it it is another name for the attrib so that both name can be used in the shaders. `GPU_vertformat_alias_add` will add an alias to the last added attribute of the format.
139	`au` is active uv layer and `u` is active uv layer for render.

Sergey Sharybin (sergey) mentioned this in D8558: Fix EEVEE not using the PBVH for rendering in Sculpt Mode.Aug 13 2020, 5:11 PM

Philipp Oeser (lichtwerk) mentioned this in T80049: Multires cannot display texture in Sculpting.Aug 24 2020, 3:03 PM

Andrey (andruxa696) awarded a token.Aug 28 2020, 4:34 PM

@Sergey Sharybin (sergey) ou mentioned in the other task that you wanted me to take over this. Is this still the case?

Pablo Dobarro (pablodp606) mentioned this in D9522: Sculpt: Add UVs to PBVH_FACES rendering.Nov 10 2020, 1:30 PM

Pablo Dobarro (pablodp606) mentioned this in T83516: Regression: multiresolution do not show texture.Dec 7 2020, 8:14 PM

Vyacheslav (hitrpr) awarded a token.Dec 7 2020, 8:48 PM

Vyacheslav (hitrpr) added a subscriber: Vyacheslav (hitrpr).

zhouxiang (zhouxiang) added a subscriber: zhouxiang (zhouxiang).Dec 13 2020, 9:12 AM

Erick Tukuniata (erickblender) added a subscriber: Erick Tukuniata (erickblender).Dec 28 2020, 5:37 PM

Nathan Clark (Neigh) added a subscriber: Nathan Clark (Neigh).Feb 10 2021, 2:05 AM

This patch has an approved status however it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect this. This way the patch status still show as Need Review.

This revision now requires review to proceed.Mar 26 2021, 6:06 PM

Evan Wilson (EAW) added a subscriber: Evan Wilson (EAW).Aug 17 2021, 6:39 PM

Steffen Hartmann (Harti) awarded a token.Oct 8 2021, 4:12 PM

Stig Oskar (Stig) awarded a token.Oct 8 2021, 4:36 PM

B (bnzs) awarded a token.Oct 9 2021, 3:48 PM