Differential D5887

Call hooks before taking copy of `scene->r` in `RE_RenderAnim()`
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Sep 24 2019, 3:37 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T66555: Handler render init ignores output placeholders

Commits

rBf94f4e1d79f7: Fix T66555: Handler render init ignores output placeholders

Summary

A change to the render output filename made in the render-init hook would
not be picked up by by the copy. As a result, placeholders were touched
using the old name, whereas the rendered images would be saved with the
new filename.

This commit fixes T66555.

Diff Detail

Repository: rB Blender

Event Timeline

Sybren A. Stüvel (sybren) created this revision.Sep 24 2019, 3:37 PM

Harbormaster completed remote builds in B5077: Diff 18454.Sep 24 2019, 3:37 PM

End comment with period

Harbormaster completed remote builds in B5078: Diff 18455.Sep 24 2019, 3:44 PM

Sergey Sharybin (sergey) added inline comments.Sep 24 2019, 3:54 PM

source/blender/render/intern/source/pipeline.c
2509	Call hooks before taking a copy of scene->r, so user can alter the render settings prior they are copied here (i.e., output path).

Review remark by Sergey

Harbormaster completed remote builds in B5079: Diff 18459.Sep 24 2019, 3:57 PM

Sybren A. Stüvel (sybren) marked an inline comment as done.Sep 24 2019, 3:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 4:00 PM

Closed by commit rBf94f4e1d79f7: Fix T66555: Handler render init ignores output placeholders (authored by Sybren A. Stüvel (sybren)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rBf94f4e1d79f7: Fix T66555: Handler render init ignores output placeholders.

Revision Contents
Changeset List

Path

Size

source/

blender/

render/

intern/

source/

pipeline.c

6 lines

Diff 18460

View Options

source/blender/render/intern/source/pipeline.c

Call hooks before taking copy of `scene->r` in `RE_RenderAnim()`ClosedPublicActions