Page MenuHome
Differential D5888

Fix T69573: Driver Value does not slide along the actual value in the Driver Editor
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Sep 24 2019, 6:26 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T69573: Driver Value does not slide along the actual value in the Driver Editor
Commits
rBfbfa904bce9b: Fix T69573: Driver Value does not slide along the actual value in the Driver…
Summary

This change is two-fold:

  • Ensure the result of the F-Curve evaluation is stored on the FCurve object. This was done in 2.79 but lost when we moved to more granular per-curve evaluation from the depsgraph.
  • Flush this result from the CoW copy back to the original.

Diff Detail

Repository
rB Blender

Event Timeline

Sybren A. Stüvel (sybren) created this revision.Sep 24 2019, 6:26 PM
Harbormaster completed remote builds in B5082: Diff 18468.Sep 24 2019, 6:26 PM
Sergey Sharybin (sergey) accepted this revision.Sep 24 2019, 6:53 PM

Seems fine.

Just spotting more and more weak aspects, but those are separate issues.

source/blender/blenkernel/intern/anim_sys.c
4085

Ideally we should store original fcurve pointer similar to how we do it in ParticleSystem::orig_psys and avoid binding subdata pointers.

This is separate story though.

4113

fcu_orig is not supposed to be NULL. Add an assert at the top and avoid NULL pointers checks later on.

4114

This seems very dodgy. Access to original is only allowed for an active dependency graph. Render thread should not be querying state of original data.
Need to dig why it's driver_orig here and not fcu->driver.

This revision is now accepted and ready to land.Sep 24 2019, 6:53 PM
Sybren A. Stüvel (sybren) marked an inline comment as done.Sep 25 2019, 10:29 AM
Sybren A. Stüvel (sybren) updated this revision to Diff 18474.Sep 25 2019, 10:30 AM
  • Changed NULL check into a BLI_assert() call
Harbormaster completed remote builds in B5087: Diff 18474.Sep 25 2019, 10:30 AM
Sybren A. Stüvel (sybren) added a task: T69573: Driver Value does not slide along the actual value in the Driver Editor.Sep 25 2019, 10:32 AM
Closed by commit rBfbfa904bce9b: Fix T69573: Driver Value does not slide along the actual value in the Driver… (authored by Sybren A. Stüvel (sybren)). · Explain WhySep 25 2019, 10:34 AM
This revision was automatically updated to reflect the committed changes.
Sybren A. Stüvel (sybren) added a commit: rBfbfa904bce9b: Fix T69573: Driver Value does not slide along the actual value in the Driver….

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
2 lines
intern/
11 lines
depsgraph/
intern/
builder/
14 lines

Diff 18475

View Options

source/blender/blenkernel/BKE_animsys.h

Loading...
View Options

source/blender/blenkernel/intern/anim_sys.c

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_nodes.cc

Loading...