Page MenuHome
Differential D5889

Sculpt: Sculpt cursor UX improvements
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Sep 24 2019, 11:27 PM.
Tags
None
Subscribers
Brecht Van Lommel (brecht)
CobraA (CobraA)
Hadrien Brissaud (hadrien)
Julien Kaspar (JulienKaspar)
Kenn Nyström (Frozen_Death_Knight)
Tokens
"Love" token, awarded by Alrob."100" token, awarded by Frozen_Death_Knight."Love" token, awarded by xrg."Love" token, awarded by jmztn."Love" token, awarded by Zino."Love" token, awarded by CobraA."Love" token, awarded by wilBr."Love" token, awarded by MetinSeven."Love" token, awarded by HARDNAX."Love" token, awarded by Tonatiuh."Mountain of Wealth" token, awarded by Way."Love" token, awarded by kioku.

Details

Reviewers
William Reynish (billreynish)
Jeroen Bakker (jbakker)
Brecht Van Lommel (brecht)
Commits
rBbe985bdde27f: Sculpt: Sculpt cursor UX improvements
Summary

This patch introduces the following changes:

  • Invert the direction of the brush strength WM control. It was working in the opposite direction to any other control in Blender. Now dragging to the right increases the strength.
  • Increase the alpha of the cursor
  • Remove the font shadow of the numbers in the WM control. It was adding too much visual noise when rendered on top of the brush alpha
  • Add a second circle to preview the strength in the cursor
  • Increase the resolution of the cursor circles. Now they look smooth even when working with large brush sizes.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Sep 24 2019, 11:27 PM
Harbormaster completed remote builds in B5085: Diff 18471.Sep 24 2019, 11:27 PM
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Sep 24 2019, 11:32 PM
Pablo Dobarro (pablodp606) added reviewers: William Reynish (billreynish), Jeroen Bakker (jbakker).
Pablo Dobarro (pablodp606) updated this revision to Diff 18472.Sep 25 2019, 12:31 AM
  • Minor tweaks
  • Increase font size
  • Hide curve texture when resizing if there is no texture enabled
  • Fix circle contrast
Harbormaster completed remote builds in B5086: Diff 18472.Sep 25 2019, 12:31 AM
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Sep 25 2019, 12:33 AM
Benjamin Sauder (kioku) awarded a token.Sep 25 2019, 9:35 AM
Way awarded a token.Sep 25 2019, 10:54 AM
Tonatiuh de San Julián (Tonatiuh) awarded a token.Sep 25 2019, 11:47 AM
Pablo Dobarro (pablodp606) updated this revision to Diff 18480.EditedSep 25 2019, 2:06 PM
  • Add curve line preview

Harbormaster completed remote builds in B5089: Diff 18480.Sep 25 2019, 2:06 PM
Pablo Dobarro (pablodp606) updated this revision to Diff 18494.Sep 25 2019, 5:07 PM
  • Increase resolution of curve texture
Harbormaster completed remote builds in B5097: Diff 18494.Sep 25 2019, 5:07 PM
Pablo Dobarro (pablodp606) added a comment.Sep 25 2019, 5:10 PM

@Jeroen Bakker (jbakker) Is it ok to increase the resolution of the preview texture? That improves the quality of the edges when previewing a curve with a sharp falloff

William Reynish (billreynish) accepted this revision.Sep 25 2019, 6:11 PM

Tested. All these changes make a surprisingly big positive difference.

  • Invert the direction of the brush strength WM control: This makes the strength work as expected - the larger the ring, the higher the strength.
  • Increase the alpha of the cursor: No idea why it was previously transparent, but it was often very hard to see. This helps a lot.
  • Add a second circle to preview the strength in the cursor: Probably the most controversial addition. I think it's ok on balance, given that it's more faded than the main brush circumference circle
  • Increase the resolution of the cursor circles: They were just slightly too low before, giving you a polygonal circle line instead of a smooth circle. This is much preferred.
  • Increase resolution of curve texture: This really helps a lot, especially for sharp falloffs where the previous low resolution was very jaggy
This revision is now accepted and ready to land.Sep 25 2019, 6:11 PM
Julien Kaspar (JulienKaspar) added a subscriber: Julien Kaspar (JulienKaspar).Sep 25 2019, 6:20 PM
[X_Z] (HARDNAX) awarded a token.Sep 25 2019, 6:23 PM
Pablo Dobarro (pablodp606) updated this revision to Diff 18496.EditedSep 25 2019, 6:57 PM
  • Make curve less white
  • Show curve only when changing strength

Harbormaster completed remote builds in B5098: Diff 18496.Sep 25 2019, 6:57 PM
Kenn Nyström (Frozen_Death_Knight) added a subscriber: Kenn Nyström (Frozen_Death_Knight).EditedSep 25 2019, 6:58 PM

Could I make a suggestion, Pablo? Could you possibly add more previews of activated brush settings as an R click option? Things like Colour, Smooth Stroke, Accumulate, Original Normal, and more in a simplified, floating list. You could also add the new Falloff preview there, since someone on the BlenderArtists forum thought that the new Falloff preview on the brush cursor itself was a bit too big and distracting. Would make a bit more sense to have a unified preview box showing all of the active settings instead of putting them on the brush cursor itself.

Personally, I really like the new Falloff preview, but I can understand if some would find it too much.

Metin Seven (MetinSeven) awarded a token.Sep 25 2019, 7:47 PM
Wilsimar (wilBr) awarded a token.Sep 25 2019, 8:22 PM
Pablo Dobarro (pablodp606) updated this revision to Diff 18501.Sep 25 2019, 10:36 PM
  • Hide gradient when resizing
Harbormaster completed remote builds in B5102: Diff 18501.Sep 25 2019, 10:36 PM
William Reynish (billreynish) accepted this revision.Sep 25 2019, 10:37 PM

Followed progress - the updates are fine with me.

Hadrien Brissaud (hadrien) added a subscriber: Hadrien Brissaud (hadrien).EditedSep 25 2019, 10:47 PM

I have to say that falloff preview looks rather distracting... not sure if that's necessary. One look to the top (or right) is enough to remind the user which falloff they've selected, if that's the intended use (?). Apart from that I like the changes. The strength direction being reversed will take some getting used to, but makes more sense. Those little tweaks really obviously come from a sculptor !

CobraA (CobraA) awarded a token.Sep 26 2019, 6:54 AM
CobraA (CobraA) added a subscriber: CobraA (CobraA).

Since this is about Cursor UX could you find a solution to make resizing the brush Cursor starts alawys from the center instead of the Outer ring? thanks.

Julien Kaspar (JulienKaspar) added a comment.Sep 26 2019, 11:30 AM
In D5889#135611, @CobraA (CobraA) wrote:

Since this is about Cursor UX could you find a solution to make resizing the brush Cursor starts alawys from the center instead of the Outer ring? thanks.

@Pablo Dobarro (pablodp606) I agree. Perhaps it would be good to have the cursor not jump when increasing the size/strength. This makes it easier to match the desired radius with the model in the background (For example matching the size to the pupil for painting an eye.
We could move the mouse right/up to increase and left/down to decrease and leave the cursor centred.

Pablo Dobarro (pablodp606) updated this revision to Diff 18525.EditedSep 26 2019, 5:49 PM
  • Don't offset the cursor preview when changing size and strength

Harbormaster completed remote builds in B5113: Diff 18525.Sep 26 2019, 5:49 PM
Zino Guerr (Zino) awarded a token.Sep 26 2019, 6:17 PM
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Sep 26 2019, 6:18 PM
Jun Mizutani (jmztn) awarded a token.Sep 26 2019, 6:19 PM
xrg (xrg) awarded a token.Sep 26 2019, 8:41 PM
Kenn Nyström (Frozen_Death_Knight) awarded a token.Sep 26 2019, 8:47 PM
srikanth (Alrob) awarded a token.Sep 26 2019, 9:47 PM
Brecht Van Lommel (brecht) accepted this revision.Sep 27 2019, 7:11 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

BKE_brush_gen_radial_control_imbuf is now generating 16x more pixels, which could become a bottleneck, though it's only computed once when starting radial control.

It would be good to multithread this one day, but I guess we'll see if it's an issue.

Closed by commit rBbe985bdde27f: Sculpt: Sculpt cursor UX improvements (authored by Pablo Dobarro (pablodp606)). · Explain WhySep 27 2019, 7:15 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rBbe985bdde27f: Sculpt: Sculpt cursor UX improvements.
Philipp Oeser (lichtwerk) mentioned this in T83603: Change Brush size does not show Falloff gradient anymore.Dec 22 2020, 5:41 PM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
4 lines
intern/
17 lines
editors/
sculpt_paint/
18 lines
windowmanager/
intern/
82 lines

Diff 18583

View Options

source/blender/blenkernel/BKE_brush.h

Loading...
View Options

source/blender/blenkernel/intern/brush.c

Loading...
View Options

source/blender/editors/sculpt_paint/paint_cursor.c

Loading...
View Options

source/blender/windowmanager/intern/wm_operators.c

Loading...