Page MenuHome
Differential D5896

Fill ProductVersion of blender executable on Windows
ClosedPublic
Actions

Authored by Laurent Noel (c2ba) on Sep 25 2019, 7:04 PM.

Details

Reviewers
Ray Molenkamp (LazyDodo)
Group Reviewers
Platform: Windows
Commits
rBae755c016765: Windows: Fill ProductVersion of blender executable
Summary

On windows, the ProductVersion field of the blender executable was empty (see https://docs.microsoft.com/en-us/windows/win32/menurc/versioninfo-resource for more information). This field might be required by windows tools such as SCCM agent to track usage statistics.

It seems that it was due to the BLEN_VER_RC_STR macro used in winblender.rc not being a string.

Diff Detail

Repository
rB Blender

Event Timeline

Laurent Noel (c2ba) created this revision.Sep 25 2019, 7:04 PM
Laurent Noel (c2ba) added a reviewer: BF Blender.
Brecht Van Lommel (brecht) edited reviewers, added: Platform: Windows; removed: BF Blender.Sep 25 2019, 7:14 PM
Ray Molenkamp (LazyDodo) mentioned this in T70251: Blender executable copyright properties.Sep 25 2019, 7:40 PM
Ray Molenkamp (LazyDodo) accepted this revision as: Ray Molenkamp (LazyDodo).Sep 25 2019, 7:56 PM
Ray Molenkamp (LazyDodo) added a subscriber: Ray Molenkamp (LazyDodo).

beyond that one whitespace change looks good

This revision is now accepted and ready to land.Sep 25 2019, 7:56 PM
Closed by commit rBae755c016765: Windows: Fill ProductVersion of blender executable (authored by Laurent Noel (c2ba), committed by Ray Molenkamp (LazyDodo)). · Explain WhySep 25 2019, 8:06 PM
This revision was automatically updated to reflect the committed changes.
Ray Molenkamp (LazyDodo) added a commit: rBae755c016765: Windows: Fill ProductVersion of blender executable.
Ray Molenkamp (LazyDodo) added a comment.Sep 25 2019, 8:08 PM

All done! thanks for the patch!

Revision Contents
Changeset List

PathSize
source/
creator/
3 lines

Diff 18495

View Options

source/creator/CMakeLists.txt

Loading...