Page MenuHome
Differential D5901

Fix T70259: Hair particle point selection if 'use_fade_time' is set
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 26 2019, 12:47 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Sebastián Barschkis (sebbas)
Jacques Lucke (JacquesLucke)
Maniphest Tasks
T70259: Hair particle selection broken in Point selection mode in specific blend file.
Commits
rBe02ecd599bdc: Fix T70259: Hair particle point selection if 'use_fade_time' is set
Summary

If fade_time is used, particles would be flagged PEK_HIDE (depending on
time settings), but since this is not respected in drawing in 2.8 yet
the user would have no indication of them keys being hidden.
Also doing this for hair doesnt make much sense anyways...

Diff Detail

Repository
rB Blender
Branch
T70259 (branched from master)
Build Status
Buildable 5106
Build 5106: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Sep 26 2019, 12:47 PM
Harbormaster completed remote builds in B5106: Diff 18507.Sep 26 2019, 12:47 PM
Philipp Oeser (lichtwerk) added a reviewer: Jacques Lucke (JacquesLucke).Sep 26 2019, 12:55 PM
Jacques Lucke (JacquesLucke) added a comment.Sep 26 2019, 2:17 PM

Comments should be full sentences (starting with a capital letter). Also usually, the automatic line-wrapping should be used for comments.

Otherwise this seems fine.

Philipp Oeser (lichtwerk) updated this revision to Diff 18510.Sep 26 2019, 2:34 PM

format comment

Harbormaster completed remote builds in B5109: Diff 18510.Sep 26 2019, 2:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2019, 3:05 PM
Closed by commit rBe02ecd599bdc: Fix T70259: Hair particle point selection if 'use_fade_time' is set (authored by Philipp Oeser (lichtwerk)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBe02ecd599bdc: Fix T70259: Hair particle point selection if 'use_fade_time' is set.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
physics/
8 lines

Diff 18507

View Options

source/blender/editors/physics/particle_edit.c

Loading...