Fix particle lasso selecting non-visible keys
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 26 2019, 12:54 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Sebastián Barschkis (sebbas)
Jacques Lucke (JacquesLucke)

Commits

rB39d855f8f32b: Fix particle lasso selecting non-visible keys

Summary

Even though hidden/faded keys are not supported in drawing in 2.8 yet,
the selection tools should not be able to select non-visible keys.

Spotted while looking into T70259

Diff Detail

Repository

rB Blender

Branch

particle_lasso_select (branched from master)

Build Status

Buildable 5107
Build 5107: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Sep 26 2019, 12:54 PM

Harbormaster completed remote builds in B5107: Diff 18508.Sep 26 2019, 12:54 PM

Looks good.

Can you add LOOP_KEYS etc to the list in .clang-format? (in a separate commit)
Then run clang-format again to correct the code style of these loops.

This revision is now accepted and ready to land.Sep 26 2019, 2:11 PM

Closed by commit rB39d855f8f32b: Fix particle lasso selecting non-visible keys (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 26 2019, 2:48 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB39d855f8f32b: Fix particle lasso selecting non-visible keys.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

physics/

particle_edit.c

2 lines

Diff 18508

View Options

source/blender/editors/physics/particle_edit.c

Fix particle lasso selecting non-visible keysClosedPublicActions