Page MenuHome
Differential D5906

Theme: Popover search
ClosedPublic
Actions

Authored by Paul (Thirio) on Sep 26 2019, 8:58 PM.

Details

Reviewers
Pablo Vazquez (pablovazquez)
William Reynish (billreynish)
Brecht Van Lommel (brecht)
Commits
rB03506ee4d145: UI: use consistent text box theme colors in search popups
Summary

This diff solves a theming issue with popover search boxes currently using the menu_back theme setting.
Issue seen on: Theme Development - Paper Cuts

Note this diff changes the appearance of the included blender_light theme. And makes text input elements more consistent.

Diff Detail

Repository
rB Blender

Event Timeline

Paul (Thirio) created this revision.Sep 26 2019, 8:58 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Sep 27 2019, 5:01 PM

Fine with me, but will leave decision to @Pablo Vazquez (pablovazquez) and @William Reynish (billreynish).

source/blender/editors/interface/interface_widgets.c
4641–4643

wcol_text is the default value alraedy, so you can just remove these 3 lines instead.

Paul (Thirio) updated this revision to Diff 18587.Sep 27 2019, 9:54 PM

Cleanup as suggested by Brecht.

noki paike (amonpaike) awarded a token.Sep 27 2019, 10:48 PM
Brecht Van Lommel (brecht) accepted this revision.Oct 2 2019, 6:58 PM

No feedback from the UI designers, I'll just go ahead and commit this since it seems straightforward.

This revision is now accepted and ready to land.Oct 2 2019, 6:58 PM
Closed by commit rB03506ee4d145: UI: use consistent text box theme colors in search popups (authored by Brecht Van Lommel (brecht)). · Explain WhyOct 2 2019, 6:58 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB03506ee4d145: UI: use consistent text box theme colors in search popups.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
3 lines

Diff 18738

View Options

source/blender/editors/interface/interface_widgets.c

Loading...