Fix T70276: View animation with jpeg 2000 image will crash player
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 27 2019, 11:13 AM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Brecht Van Lommel (brecht)

Maniphest Tasks

T70276: View animation with jpeg 2000 image files leads to segfault

Commits

rBc5db0272d4be: Fix T70276: View animation with jpeg 2000 image will crash player

Summary

Afaict, our ffmpeg can decode jpeg 2000 (in both J2K and JP2 codec flavors
as well as high bitdepths), so added these extensions to the supported
list. (havent checked if the ffmpeg we build depends on
WITH_IMAGE_OPENJPEG?)

Also IMB_ispic > IMB_ispic_type > imb_is_a_jp2 was only testing for jp2,
now do both jp2/j2k.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Sep 27 2019, 11:13 AM

Harbormaster completed remote builds in B5121: Diff 18552.Sep 27 2019, 11:13 AM

We build ffmpeg with openjpeg support, see build_files/build_environment/cmake/ffmpeg.cmake.

This revision is now accepted and ready to land.Sep 27 2019, 11:51 AM

Closed by commit rBc5db0272d4be: Fix T70276: View animation with jpeg 2000 image will crash player (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 27 2019, 12:05 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBc5db0272d4be: Fix T70276: View animation with jpeg 2000 image will crash player.

Revision Contents
Changeset List

Path

Size

source/

blender/

imbuf/

intern/

jp2.c

2 lines

util.c

2 lines

Diff 18554

View Options

source/blender/imbuf/intern/jp2.c