Differential D5912

Fix particle editmode undo not doing proper updates when child particles are visible
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 27 2019, 2:57 PM.

Tags

None

Subscribers

None

Details

Reviewers

Sergey Sharybin (sergey)
Campbell Barton (campbellbarton)
Sebastián Barschkis (sebbas)
Jacques Lucke (JacquesLucke)

Commits

rB0647232ac545: Fix particle editmode undo not doing proper updates when child particles are…

Summary

Not freeing PTCacheEdit and tagging batch cache dirty on undo will have
a couple of consequences. This patch fixes:

crash deleting a particle, then undo
basically any edit (combing, ...), then undo will leave child hairs untouched
adding hairs (through mirror, add tool, ...), then undo will leave 'orphaned' child hairs

See also D5755 for a related discussion

Fixes the crasher mentioned in T69000

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Sep 27 2019, 2:57 PM

Harbormaster completed remote builds in B5124: Diff 18557.Sep 27 2019, 2:57 PM

Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Sep 27 2019, 3:16 PM

Philipp Oeser (lichtwerk) added a reviewer: Jacques Lucke (JacquesLucke).Sep 27 2019, 3:40 PM

Garry R. Osgood (grosgood) mentioned this in T69000: Hair: changing children related settings not updating in particle editmode.Oct 31 2019, 11:47 PM

This is something what happens in a lot of other places. Worth moving those lines to an utility function.

Other than that it seems fine for master. For 2.81 might be a bit too dangerous?

This revision is now accepted and ready to land.Nov 4 2019, 10:19 AM

Sergey Sharybin (sergey) mentioned this in D5925: Fix (unreported) hair particle 'Delete Edit' missing children hair updates in particle editmode.Nov 4 2019, 10:22 AM

Closed by commit rB0647232ac545: Fix particle editmode undo not doing proper updates when child particles are… (authored by Philipp Oeser (lichtwerk)). · Explain WhyDec 19 2019, 9:05 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB0647232ac545: Fix particle editmode undo not doing proper updates when child particles are….

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

physics/

particle_edit_undo.c

5 lines

Diff 20424

source/blender/editors/physics/particle_edit_undo.c

Loading...