Page MenuHome
Differential D5920

Fix T70299: Grab brush not working as expected when Ctrl is press
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Sep 27 2019, 4:52 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Brecht Van Lommel (brecht)
Maniphest Tasks
T70299: Sculpt: Grab brush not working as expected when Ctrl is press.
Commits
rB3bbe01dad33c: Fix T70299: Grab brush not working as expected when Ctrl is press

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Sep 27 2019, 4:52 PM
Harbormaster completed remote builds in B5132: Diff 18568.Sep 27 2019, 4:52 PM
Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Sep 27 2019, 4:53 PM
Brecht Van Lommel (brecht) accepted this revision.Sep 27 2019, 5:16 PM
This revision is now accepted and ready to land.Sep 27 2019, 5:16 PM
Pablo Dobarro (pablodp606) updated this revision to Diff 18572.Sep 27 2019, 5:20 PM
  • Enable the fix only in grab

I'm not sure if the previous solution breaks the behaivour in other brushes that use normal weight. In the grab brush it does not make sense to update it per step

Harbormaster completed remote builds in B5135: Diff 18572.Sep 27 2019, 5:20 PM
Brecht Van Lommel (brecht) added a comment.Sep 27 2019, 5:29 PM

The only other tool using normal weight is snake hook, so it should be easy to verify if that one needs it too?

Metin Seven (MetinSeven) awarded a token.Sep 27 2019, 7:52 PM
Pablo Dobarro (pablodp606) updated this revision to Diff 18652.Sep 30 2019, 3:41 PM
  • The previous fix was causing other issues. I think this should work.
Harbormaster completed remote builds in B5178: Diff 18652.Sep 30 2019, 3:41 PM
Closed by commit rB3bbe01dad33c: Fix T70299: Grab brush not working as expected when Ctrl is press (authored by Pablo Dobarro (pablodp606)). · Explain WhyOct 3 2019, 3:33 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rB3bbe01dad33c: Fix T70299: Grab brush not working as expected when Ctrl is press.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
3 lines

Diff 18755

View Options

source/blender/editors/sculpt_paint/sculpt.c

Loading...