Differential D5921

Fix T70281: Changing Default interpolation also changes curve of new drivers
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Sep 27 2019, 5:03 PM.

Tags

Subscribers

None

Details

Reviewers

Alexander Gavrilov (angavrilov)
Joshua Leung (aligorith)

Maniphest Tasks

T70281: Changing Default interpolation also changes curve of new drivers

Commits

rB3370af2dc1ce: Fix T70281: Changing Default interpolation also changes curve of new drivers

Summary

Having a constant FCurve doesn't make sense for drivers, even when the user preference is set to have those by default; either linear or Bezier should be used. Since the code is already creating a Bezier curve, I just added the flag to not look at the user preferences in this case.

This fixes T70281.

Diff Detail

Repository: rB Blender

Event Timeline

Sybren A. Stüvel (sybren) created this revision.Sep 27 2019, 5:03 PM

Harbormaster completed remote builds in B5134: Diff 18571.Sep 27 2019, 5:03 PM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Sep 27 2019, 5:03 PM

Sybren A. Stüvel (sybren) added projects: BF Blender (2.81), Animation & Rigging.

Sybren A. Stüvel (sybren) added a task: T70281: Changing Default interpolation also changes curve of new drivers.

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)

Seems ok, except if interpolation and handle type is now guaranteed, I don't see the point of changing handle type to vector just after.

source/blender/editors/animation/drivers.c
141–142	I wonder what's the point of this - two keys with bezier and linear extrapolation already makes it linear.

This revision is now accepted and ready to land.Oct 1 2019, 11:36 AM

Remove explicitly setting the handle types to Vector.

Harbormaster completed remote builds in B5186: Diff 18667.Oct 1 2019, 11:54 AM

Closed by commit rB3370af2dc1ce: Fix T70281: Changing Default interpolation also changes curve of new drivers (authored by Sybren A. Stüvel (sybren)). · Explain WhyOct 1 2019, 11:59 AM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rB3370af2dc1ce: Fix T70281: Changing Default interpolation also changes curve of new drivers.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

animation/

12 lines

Diff 18668

source/blender/editors/animation/drivers.c

Loading...