Page MenuHome
Differential D5925

Fix (unreported) hair particle 'Delete Edit' missing children hair updates in particle editmode
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 27 2019, 11:03 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Jacques Lucke (JacquesLucke)
Sebastián Barschkis (sebbas)
Commits
rBecfb7eab0ca7: Fix (unreported) hair particle 'Delete Edit' missing children hair updates in…
Summary

Particles themselves were cleared correctly but this was not tagging
batch cache dirty.
There are many occurances where this tagging is done by hand, I really
wonder if this should be moved to 'psys_free_path_cache' /
'free_child_path_cache'?

Diff Detail

Repository
rB Blender
Branch
particle_delete_edit_missing_editcache_dirtytag (branched from master)
Build Status
Buildable 5142
Build 5142: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Sep 27 2019, 11:03 PM
Harbormaster completed remote builds in B5142: Diff 18590.Sep 27 2019, 11:03 PM
Sergey Sharybin (sergey) accepted this revision.Nov 4 2019, 10:22 AM

Generally fine, but i wouldn't mind if there is an utility function introduced and re-used for D5912 as well.

This revision is now accepted and ready to land.Nov 4 2019, 10:22 AM
Closed by commit rBecfb7eab0ca7: Fix (unreported) hair particle 'Delete Edit' missing children hair updates in… (authored by Philipp Oeser (lichtwerk)). · Explain WhyDec 19 2019, 9:05 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBecfb7eab0ca7: Fix (unreported) hair particle 'Delete Edit' missing children hair updates in….

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
physics/
1 line

Diff 18590

View Options

source/blender/editors/physics/particle_edit.c

Loading...