William Reynish (billreynish) retitled this revision from Use paint crosshair cursor in all paint modes to Use paint crosshair cursor in all paint & sculpt modes.

@Matias Mendiola (mendio) @Daniel Martinez Lara (pepeland) Could you test in GPencil?

@William Reynish (billreynish) Why don't put the same cursor for the other GPencil tools as I did in D5145? Really, Primitives or Annotations are also Drawing tools, no?

In D5940#136510, @Antonio Vazquez (antoniov) wrote:

@William Reynish (billreynish) Why don't put the same cursor for the other GPencil tools as I did in D5145? Really, Primitives or Annotations are also Drawing tools, no?

Primitives are not painting. We currently use the regular crosshair cursor for many things not related to painting.
Annotations: We could change the annotation cursor, but currently it uses the pencil cursor. I have no strong opinion on the Annotation tool and it's cursors.

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Sep 29 2019, 8:56 PM

Brecht Van Lommel (brecht) added inline comments.

release/scripts/startup/bl_ui/space_toolsystem_toolbar.py
53–57	Instead of hardcoding this for grease pencil, add a `cursor=None,` parameter to `generate_from_enum_ex`, and pass `cursor='PAINT_CROSS'` where needed.

Antonio Vazquez (antoniov) commandeered this revision.Sep 30 2019, 9:12 AM

Antonio Vazquez (antoniov) added a reviewer: William Reynish (billreynish).

Use parameter instead of hardcode

Harbormaster completed remote builds in B5169: Diff 18638.Sep 30 2019, 9:13 AM

@William Reynish (billreynish) I think now is correct.

Brecht Van Lommel (brecht) accepted this revision.Sep 30 2019, 10:49 AM

This revision is now accepted and ready to land.Sep 30 2019, 10:49 AM

After testing it, I found the crosshair is a little intrusive in my opinion, when your are drawing fine details this crosshair is visual mixing with your real fine strokes and you need displace the crosshair to see how looks your details. A more small crosshair will be better IMO

Affinity Photo (and Photoshop optionally) have a painting cursor that is just the brush size circle, that has always felt the most natural to me, I agree with @Daniel Martinez Lara (pepeland) having anything in the centre is obtrusive with finer details.

Closed by commit rB04ef62177fb6: UI: Use paint crosshair cursor in all paint & sculpt modes (authored by William Reynish (billreynish)). · Explain WhySep 30 2019, 1:34 PM

This revision was automatically updated to reflect the committed changes.

William Reynish (billreynish) added a commit: rB04ef62177fb6: UI: Use paint crosshair cursor in all paint & sculpt modes.

Antonio Vazquez (antoniov) mentioned this in T62446: Mouse cursor disappears on Grease Pencil stroke.Oct 2 2019, 8:47 AM