Fix T70376: Lattice point looses state on modeswitch when shape keys are present
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 30 2019, 4:36 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Bastien Montagne (mont29)

Maniphest Tasks

T70376: Lattice point selection state with shape keys

Commits

rBe82ac9e596de: Fix T70376: Lattice point looses state on modeswitch when shape keys are present

Summary

Selection state of lattice points as well as their weight where not kept when going in and out of editmode, code would just copy positions.
Now copy the whole BPoint instead.

Diff Detail

Repository

rB Blender

Branch

T70376 (branched from master)

Build Status

Buildable 5179
Build 5179: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Sep 30 2019, 4:36 PM

Harbormaster completed remote builds in B5179: Diff 18655.Sep 30 2019, 4:37 PM

While the patch is fine, it might be less error prone to copy the entire struct, otherwise some other member might get left out in the future.

*Edit* the weight isn't being copied back, which is editable in lattice edit mode.

Campbell Barton (campbellbarton) requested changes to this revision.Sep 30 2019, 6:27 PM

This revision now requires changes to proceed.Sep 30 2019, 6:27 PM

copy whole BPoint instead

Harbormaster completed remote builds in B5183: Diff 18664.Oct 1 2019, 10:05 AM

Philipp Oeser (lichtwerk) retitled this revision from Fix T70376: Lattice point selection state not kept with shape keys to Fix T70376: Lattice point looses state on modeswitch when shape keys are present.Oct 1 2019, 10:05 AM

Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)

Campbell Barton (campbellbarton) accepted this revision.Oct 1 2019, 11:50 AM

This revision is now accepted and ready to land.Oct 1 2019, 11:50 AM

Closed by commit rBe82ac9e596de: Fix T70376: Lattice point looses state on modeswitch when shape keys are present (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 1 2019, 12:54 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBe82ac9e596de: Fix T70376: Lattice point looses state on modeswitch when shape keys are present.