Paths

Table of Contentst

Differential D5966

Proposed fix for T70399
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Oct 2 2019, 10:20 AM.

Details

Reviewers

Clément Foucault (fclem)

Commits

rBddd40985e7df: Fix T70399: Grease Pencil Canvas Grid Overlay Broken after DRW refactor

Summary

Now the grid matrix is calculated when the shading group is created.

Also, the grid pass is only created when needed and reduce memory usage when the scene is not using grease pencil objects.

Diff Detail

Repository: rB Blender

Event Timeline

Antonio Vazquez (antoniov) created this revision.Oct 2 2019, 10:20 AM

Harbormaster completed remote builds in B5202: Diff 18707.Oct 2 2019, 10:20 AM

Antonio Vazquez (antoniov) mentioned this in T70399: Grease Pencil Canvas Grid Overlay Broken after DRW refactor.Oct 2 2019, 10:20 AM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

Antonio Vazquez (antoniov) added a reviewer: Clément Foucault (fclem).

Antonio Vazquez (antoniov) added a project: Grease Pencil.

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Oct 2 2019, 10:22 AM

@Clément Foucault (fclem) If you give the ok, I will commit this fix for T70399.

Antonio Vazquez (antoniov) added a project: BF Blender.Oct 2 2019, 10:27 AM

Clément Foucault (fclem) requested changes to this revision.Oct 2 2019, 2:04 PM

Clément Foucault (fclem) added inline comments.

source/blender/draw/engines/gpencil/gpencil_engine.c
710	if it uses `gpModelMatrix` in the shader, no need to use `DRW_shgroup_call_obmat`. Use `DRW_shgroup_call` with `ob = NULL`.

This revision now requires changes to proceed.Oct 2 2019, 2:04 PM

GPencil: Use DRW_shgroup_call

Harbormaster completed remote builds in B5208: Diff 18724.Oct 2 2019, 3:16 PM

Clément Foucault (fclem) accepted this revision.Oct 2 2019, 3:27 PM

This revision is now accepted and ready to land.Oct 2 2019, 3:27 PM

Closed by commit rBddd40985e7df: Fix T70399: Grease Pencil Canvas Grid Overlay Broken after DRW refactor (authored by Antonio Vazquez (antoniov)). · Explain WhyOct 2 2019, 3:33 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rBddd40985e7df: Fix T70399: Grease Pencil Canvas Grid Overlay Broken after DRW refactor.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

gpencil/

gpencil_engine.h

1 line

gpencil_engine.c

67 lines

Diff 18725

View Options

source/blender/draw/engines/gpencil/gpencil_engine.h