Page MenuHome
Differential D5967

Theme: NLA Channel and Track
ClosedPublic
Actions

Authored by Paul (Thirio) on Oct 2 2019, 10:58 AM.

Details

Reviewers
Pablo Vazquez (pablovazquez)
William Reynish (billreynish)
Brecht Van Lommel (brecht)
Commits
rBd1a1302b01f4: UI: add NLA track and channel theme color
Summary

Existing dopesheet_channel added to the theme editor.
And a new nla_track color added to separate the color from the theme space header.

Issue seen on: Theme Development - Paper Cuts

Diff Detail

Repository
rB Blender

Event Timeline

Paul (Thirio) created this revision.Oct 2 2019, 10:58 AM
Paul (Thirio) edited the summary of this revision. (Show Details)Oct 2 2019, 11:03 AM
Brecht Van Lommel (brecht) requested changes to this revision.Oct 2 2019, 12:03 PM

The new nla_track color needs to be initialized for existing preferences in do_versions_theme in versioning_userdef.c.

Something like:

copy_v4_v4_uchar(btheme->space_nla.nla_track, btheme->space_nla.header);
release/datafiles/userdef/userdef_default_theme.c
588

Set alpha to 1, even if not used now: 0x424242ff

This revision now requires changes to proceed.Oct 2 2019, 12:03 PM
Paul (Thirio) updated this revision to Diff 18720.Oct 2 2019, 3:01 PM
Paul (Thirio) edited the summary of this revision. (Show Details)

Thanks, Brecht! I've added the initialization for existing preferences under

/**
 * Include next version bump.
 */

And set the alpha of the new color to 1.

Brecht Van Lommel (brecht) accepted this revision.Oct 2 2019, 3:10 PM
This revision is now accepted and ready to land.Oct 2 2019, 3:10 PM
Closed by commit rBd1a1302b01f4: UI: add NLA track and channel theme color (authored by Brecht Van Lommel (brecht)). · Explain WhyOct 2 2019, 6:58 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBd1a1302b01f4: UI: add NLA track and channel theme color.

Revision Contents
Changeset List

PathSize
release/
datafiles/
userdef/
3 lines
source/
blender/
blenloader/
intern/
1 line
editors/
animation/
2 lines
include/
1 line
interface/
3 lines
makesdna/
3 lines
makesrna/
intern/
12 lines

Diff 18739

View Options

release/datafiles/userdef/userdef_default_theme.c

Loading...
View Options

source/blender/blenloader/intern/versioning_userdef.c

Loading...
View Options

source/blender/editors/animation/anim_channels_defines.c

Loading...
View Options

source/blender/editors/include/UI_resources.h

Loading...
View Options

source/blender/editors/interface/resources.c

Loading...
View Options

source/blender/makesdna/DNA_userdef_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_userdef.c

Loading...