Page MenuHome
Differential D5994

Sculpt: Update only modified grids on multires undo
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 5 2019, 3:41 PM.
Tags
None
Subscribers
Steffen Dünner (SteffenD)
Tokens
"Love" token, awarded by brilliant_ape."Love" token, awarded by tiagoffcruz."Love" token, awarded by johnsyed."100" token, awarded by Frozen_Death_Knight.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBafb9bdc320ae: Sculpt: Update only modified grids on multires undo
Summary

This makes multires undo much faster and fixes the viewport lag after and undo operation.

Diff Detail

Repository
rB Blender
Branch
multires-undo- (branched from master)
Build Status
Buildable 5255
Build 5255: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Oct 5 2019, 3:41 PM
Harbormaster completed remote builds in B5250: Diff 18809.Oct 5 2019, 3:41 PM
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Oct 5 2019, 3:45 PM
Pablo Dobarro (pablodp606) added a reviewer: Brecht Van Lommel (brecht).
Kenn Nyström (Frozen_Death_Knight) awarded a token.Oct 5 2019, 4:05 PM
babajan (johnsyed) awarded a token.Oct 5 2019, 9:29 PM
Tiago Cruz (tiagoffcruz) awarded a token.Oct 5 2019, 9:40 PM
Brecht Van Lommel (brecht) requested changes to this revision.Oct 5 2019, 10:47 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/editors/sculpt_paint/sculpt_undo.c
103–110

This is a loop with O(n^2) time complexity which can get really bad when doing e.g. mesh filter on multires with a high poly base mesh. 10k grids can lead to ~100 million iterations, and it gets words as the number of grids grows.

Instead create a char array that says for a given grid index if the grid was updated or not, and then do a lookup with c_grid_index into it.

This revision now requires changes to proceed.Oct 5 2019, 10:47 PM
Pablo Dobarro (pablodp606) updated this revision to Diff 18818.Oct 5 2019, 11:05 PM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Review update
Harbormaster completed remote builds in B5255: Diff 18818.Oct 5 2019, 11:05 PM
Brecht Van Lommel (brecht) accepted this revision.Oct 5 2019, 11:24 PM
This revision is now accepted and ready to land.Oct 5 2019, 11:24 PM
Ted Nielsen (brilliant_ape) awarded a token.Oct 6 2019, 1:13 AM
Steffen Dünner (SteffenD) added a subscriber: Steffen Dünner (SteffenD).Oct 6 2019, 10:44 PM
Closed by commit rBafb9bdc320ae: Sculpt: Update only modified grids on multires undo (authored by Pablo Dobarro (pablodp606)). · Explain WhyOct 7 2019, 3:22 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rBafb9bdc320ae: Sculpt: Update only modified grids on multires undo.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
58 lines

Diff 18818

View Options

source/blender/editors/sculpt_paint/sculpt_undo.c

Loading...