Page MenuHome
Differential D6000

Fix T69682: Render Audio ignores animation.
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Oct 6 2019, 8:25 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T69682: "Render Audio..." does not always render keyframe transitions that have been placed in Volume, Pitch or Pan.
Commits
rB6d3c34fe9d1e: Fix T69682: Render Audio ignores animation.
Summary

sound_update_animation_flags_exec didn't tag depsgraph to update.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) created this revision.Oct 6 2019, 8:25 AM
Harbormaster completed remote builds in B5256: Diff 18819.Oct 6 2019, 8:25 AM
Sergey Sharybin (sergey) requested changes to this revision.Oct 6 2019, 10:54 AM
Sergey Sharybin (sergey) added inline comments.
source/blender/editors/sound/sound_ops.c
363

This doesn't make sense to me. DEG_get_evaluated_scene() simply returns pointer, which stays the same during lifetime of dependency graph.

So either this part is not needed, or it is CTX_data_ensure_evaluated_depsgraph which is to be called after edits which happens in sound_bake_animation_exec().

This revision now requires changes to proceed.Oct 6 2019, 10:54 AM
Richard Antalik (ISS) updated this revision to Diff 18822.Oct 6 2019, 2:03 PM
  • Remove unnecessary change
Harbormaster completed remote builds in B5259: Diff 18822.Oct 6 2019, 2:03 PM
Richard Antalik (ISS) marked an inline comment as done.Oct 6 2019, 2:04 PM
Richard Antalik (ISS) added inline comments.
source/blender/editors/sound/sound_ops.c
363

Sorry, I should tell, that I am unsure about this.

Sergey Sharybin (sergey) accepted this revision.Oct 6 2019, 5:03 PM
This revision is now accepted and ready to land.Oct 6 2019, 5:03 PM
Closed by commit rB6d3c34fe9d1e: Fix T69682: Render Audio ignores animation. (authored by Richard Antalik (ISS)). · Explain WhyOct 8 2019, 10:11 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) marked an inline comment as done.
Richard Antalik (ISS) added a commit: rB6d3c34fe9d1e: Fix T69682: Render Audio ignores animation..
Frantisek Dobrota (DaveOshiCZ) mentioned this in T85491: EXCEPTION_ACCESS_VIOLATION.Feb 9 2021, 10:46 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sound/
3 lines

Diff 18884

View Options

source/blender/editors/sound/sound_ops.c

Loading...