Differential D6001

Fix T70560: Large cones are created with double vertices (even though the radius is zero)
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 6 2019, 10:24 AM.

Tags

None

Subscribers

None

Details

Reviewers

Campbell Barton (campbellbarton)
Bastien Montagne (mont29)

Maniphest Tasks

T70560: Large cones are created with double vertices (even though the radius is zero)

Commits

rBfa76f08db5c5: Fix T70560: Large cones are created with double vertices (even though the…

Summary

Merge threshold for remove_doubles was hardcoded, now scaled by depth.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 6 2019, 10:24 AM

Harbormaster completed remote builds in B5257: Diff 18820.Oct 6 2019, 10:24 AM

Campbell Barton (campbellbarton) accepted this revision.Oct 14 2019, 12:36 PM

This revision is now accepted and ready to land.Oct 14 2019, 12:36 PM

Note that creating doubles in the first place isn't great, adding TODO: T70808: Avoid creating doubles in UV-Sphere primitive

Closed by commit rBfa76f08db5c5: Fix T70560: Large cones are created with double vertices (even though the… (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 15 2019, 9:52 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBfa76f08db5c5: Fix T70560: Large cones are created with double vertices (even though the….

Revision Contents
Changeset List

Path

Size

source/

blender/

bmesh/

operators/

bmo_primitive.c

2 lines

Diff 19017

source/blender/bmesh/operators/bmo_primitive.c

Loading...