Page MenuHome
Differential D6010

Sculpt: Fix projection artifacts by changing the voxel remesh isovalue
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 7 2019, 4:51 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Sebastian Parborg (zeddb)
Commits
rBabc36cad8339: Sculpt: Fix projection artifacts by changing the voxel remesh isovalue

Diff Detail

Repository
rB Blender
Branch
remesh-isovalue-fix (branched from master)
Build Status
Buildable 5269
Build 5269: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Oct 7 2019, 4:51 PM
Harbormaster completed remote builds in B5269: Diff 18843.Oct 7 2019, 4:51 PM
Pablo Dobarro (pablodp606) added reviewers: Jeroen Bakker (jbakker), Sebastian Parborg (zeddb).Oct 7 2019, 4:52 PM
Sebastian Parborg (zeddb) added inline comments.Oct 7 2019, 5:35 PM
source/blender/blenkernel/intern/mesh_remesh_voxel.c
310

Shouldn't isovalue and adaptivity be case to double rather than float?

Sebastian Parborg (zeddb) added inline comments.Oct 7 2019, 5:36 PM
source/blender/blenkernel/intern/mesh_remesh_voxel.c
310

*cast

Pablo Dobarro (pablodp606) updated this revision to Diff 18846.Oct 7 2019, 5:39 PM
Pablo Dobarro (pablodp606) marked 2 inline comments as done.
  • Fix cast
Harbormaster completed remote builds in B5272: Diff 18846.Oct 7 2019, 5:39 PM
Sebastian Parborg (zeddb) accepted this revision.Oct 7 2019, 6:00 PM

LGTM. But I haven't really tested this excessively, only with a few simple objects.

This revision is now accepted and ready to land.Oct 7 2019, 6:00 PM
Pablo Dobarro (pablodp606) added a comment.Oct 7 2019, 6:02 PM

I can also add to this the recalculate normals fix in D6008. Then, in theory, all voxel remesh artifacts reports should be fixed.

Sebastian Parborg (zeddb) added a comment.Oct 7 2019, 6:21 PM

Sure, that is fine by me as both of these are quite small patches.

Pablo Dobarro (pablodp606) updated this revision to Diff 18851.Oct 7 2019, 6:31 PM
  • Recalculate normals after fix poles
Harbormaster completed remote builds in B5275: Diff 18851.Oct 7 2019, 6:31 PM
Closed by commit rBabc36cad8339: Sculpt: Fix projection artifacts by changing the voxel remesh isovalue (authored by Pablo Dobarro (pablodp606)). · Explain WhyOct 8 2019, 3:57 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rBabc36cad8339: Sculpt: Fix projection artifacts by changing the voxel remesh isovalue.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
3 lines
intern/
7 lines
1 line
editors/
object/
7 lines

Diff 18843

View Options

source/blender/blenkernel/BKE_mesh_remesh_voxel.h

Loading...
View Options

source/blender/blenkernel/intern/mesh_remesh_voxel.c

Loading...
View Options

source/blender/blenkernel/intern/shrinkwrap.c

Loading...
View Options

source/blender/editors/object/object_remesh.c

Loading...