GPU: show more descriptive labels on unsupported GPU dialog
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Oct 8 2019, 7:31 PM.

Details

Reviewers

Ray Molenkamp (LazyDodo)

Maniphest Tasks

T70521: Better button labels for limited and unsupported GPU warning

Commits

rBcf682b9dab36: GPU: show more descriptive labels on unsupported GPU dialog

Summary

@Ray Molenkamp (LazyDodo), I'm having some trouble getting this to build since TASKDIALOGCONFIG
is missing, even if it is supposed to be in commctrl.h.

I believe this happens because we are not building with a new enough Windows SDK
version or something, but I couldn't easily find how to fix this.

Fixes T70521

Diff Detail

Repository: rB Blender

Event Timeline

Brecht Van Lommel (brecht) created this revision.Oct 8 2019, 7:31 PM

Harbormaster completed remote builds in B5292: Diff 18879.Oct 8 2019, 7:31 PM

near the top of GHOST_SystemWin32.cpp , it changes the target version back to XP, just remove it, it's being set correctly in platform_win32.cmake

#define _WIN32_WINNT 0x501

small build fixes

Harbormaster completed remote builds in B5293: Diff 18880.Oct 8 2019, 7:54 PM

There were some other linker shenanigans, builds now, but it didn't seem to give me a warn on mesa/llvm pipe on windows, so i didn't actually see the dialog.

manually added it to the blacklist, dialog seems to work!