UI: add text cursor theme color
ClosedPublic
Actions

Authored by Paul (Thirio) on Oct 8 2019, 9:05 PM.

Details

Reviewers

Pablo Vazquez (pablovazquez)
Brecht Van Lommel (brecht)
William Reynish (billreynish)

Commits

rBb374b24f1b2d: UI: Widget Text Cursor Color

Summary

This diff adds a Global Text Cursor Color under User Interface > Styles

Diff Detail

Repository: rB Blender

Event Timeline

Paul (Thirio) created this revision.Oct 8 2019, 9:05 PM

Alessio Monti di Sopra (a.monti) mentioned this in D6295: UI: Widget Text Cursor Color.Nov 23 2019, 10:41 PM

Looks good to me. But you should add an operator description - last arg to RNA_def_property_ui_text() in rna_userdef.c.

Added operator description.

Thank you, Harley, that was a bit lazy of me.

I found that most descriptions are missing and that when they start with the property type and end with the property name they read best.

Hey Paul, I'd like to commit this (with you set as author) but for me to do so I need the email address that you use here and whatever name you prefer. So hoping you could DM me that info using any of the methods to get in touch with me shown on the following page: https://developer.blender.org/p/harley/

This revision was not accepted when it landed; it landed in state Needs Review.Nov 25 2019, 5:38 PM

Closed by commit rBb374b24f1b2d: UI: Widget Text Cursor Color (authored by Paul (Thirio), committed by Harley Acheson (harley)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harley Acheson (harley) added a commit: rBb374b24f1b2d: UI: Widget Text Cursor Color.